Skip to contentSkip to conversation

gpio: langwell: remove unnecessary platform_set_drvdata()

PATCH In review Jingoo Han 2 participants 2 messages May 6, 2013 – May 30, 2013 GPIO

lore
Share & tools
lore

Jingoo Han

author
#0 lore raw

PATCH 1/7 gpio: langwell: remove unnecessary platform_set_drvdata()

The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.

---
 drivers/gpio/gpio-langwell.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/gpio/gpio-langwell.c +0 -1
index 634c3d3..de08bc1 100644
@@ -478,7 +478,6 @@ static int wp_gpio_remove(struct platform_device *pdev)
 		dev_err(&pdev->dev, "failed to remove gpio_chip.\n");
 	iounmap(lnw->reg_base);
 	kfree(lnw);
-	platform_set_drvdata(pdev, NULL);
 	return 0;
 }
 
Signature · 1 line
1.7.2.5
#1 lore raw
Quoted 6 lines · Jingoo Han

The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.

Patch applied.

Yours,
Linus Walleij