Skip to contentSkip to conversation

fs/f2fs: atomically set inode->i_flags

PATCH New Zhang Zhen 2 participants 3 messages Aug 24, 2015 1 message not in the archive F2FS file system

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Zhang Zhen

author
#1 lore raw

PATCH 1/1 fs/f2fs: atomically set inode->i_flags

According to commit 5f16f3225b06 ("ext4: atomically set inode->i_flags in ext4_set_inode_flags()").

Signed-off-by Zhang Zhen <[email protected]>
---
 fs/f2fs/inode.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
fs/f2fs/inode.c +2 -3
index 2550868..141ca63 100644
@@ -12,7 +12,6 @@
 #include <linux/f2fs_fs.h>
 #include <linux/buffer_head.h>
 #include <linux/writeback.h>
-#include <linux/bitops.h>
 
 #include "f2fs.h"
 #include "node.h"

@@ -34,8 +33,8 @@ void f2fs_set_inode_flags(struct inode *inode)
 		new_fl |= S_NOATIME;
 	if (flags & FS_DIRSYNC_FL)
 		new_fl |= S_DIRSYNC;
-	set_mask_bits(&inode->i_flags,
-			S_SYNC|S_APPEND|S_IMMUTABLE|S_NOATIME|S_DIRSYNC, new_fl);
+	inode_set_flags(inode, new_fl,
+			S_SYNC|S_APPEND|S_IMMUTABLE|S_NOATIME|S_DIRSYNC);
 }
 
 static void __get_inode_rdev(struct inode *inode, struct f2fs_inode *ri)
Signature · 10 lines
1.9.1


.





------------------------------------------------------------------------------
author
#2 lore raw

PATCH 1/1 fs/f2fs: atomically set inode->i_flags

According to commit 5f16f3225b06 ("ext4: atomically set inode->i_flags in ext4_set_inode_flags()").

Signed-off-by Zhang Zhen <[email protected]>
---
 fs/f2fs/inode.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
fs/f2fs/inode.c +2 -3
index 2550868..141ca63 100644
@@ -12,7 +12,6 @@
 #include <linux/f2fs_fs.h>
 #include <linux/buffer_head.h>
 #include <linux/writeback.h>
-#include <linux/bitops.h>
 
 #include "f2fs.h"
 #include "node.h"

@@ -34,8 +33,8 @@ void f2fs_set_inode_flags(struct inode *inode)
 		new_fl |= S_NOATIME;
 	if (flags & FS_DIRSYNC_FL)
 		new_fl |= S_DIRSYNC;
-	set_mask_bits(&inode->i_flags,
-			S_SYNC|S_APPEND|S_IMMUTABLE|S_NOATIME|S_DIRSYNC, new_fl);
+	inode_set_flags(inode, new_fl,
+			S_SYNC|S_APPEND|S_IMMUTABLE|S_NOATIME|S_DIRSYNC);
 }
 
 static void __get_inode_rdev(struct inode *inode, struct f2fs_inode *ri)
Signature · 12 lines
1.9.1


.







------------------------------------------------------------------------------
Reviewed-by on v1 1/1
#3 lore raw
Quoted 11 lines

-----Original Message-----
From: Zhang Zhen [mailto:[email protected]]
Sent: Monday, August 24, 2015 11:29 AM
To: [email protected]; [email protected]
Cc: [email protected]
Subject: [f2fs-dev] [PATCH] fs/f2fs: atomically set inode->i_flags

According to commit 5f16f3225b06 ("ext4: atomically set inode->i_flags in ext4_set_inode_flags()").

Signed-off-by Zhang Zhen <[email protected]>
Reviewed-by Chao Yu <[email protected]>

------------------------------------------------------------------------------