Skip to contentSkip to conversation

net: phy: spi_ks8995: remove unnecessary spi_set_drvdata()

PATCH New Jingoo Han 1 participant 1 message Nov 25, 2013

Subsystems (3)
lore
Share & tools
lore

Jingoo Han

author
#0 lore raw

PATCH 1/1 net: phy: spi_ks8995: remove unnecessary spi_set_drvdata()

The driver core clears the driver data to NULL after device_release or on probe failure. Thus, it is not needed to manually clear the device driver data to NULL.

---
 drivers/net/phy/spi_ks8995.c |    2 --
 1 file changed, 2 deletions(-)
drivers/net/phy/spi_ks8995.c +0 -2
index f3bea13..98fb9f3 100644
@@ -325,7 +325,6 @@ static int ks8995_probe(struct spi_device *spi)
 	return 0;
 
 err_drvdata:
-	spi_set_drvdata(spi, NULL);
 	kfree(ks);
 	return err;
 }
@@ -337,7 +336,6 @@ static int ks8995_remove(struct spi_device *spi)
 	ks8995 = spi_get_drvdata(spi);
 	sysfs_remove_bin_file(&spi->dev.kobj, &ks8995_registers_attr);
 
-	spi_set_drvdata(spi, NULL);
 	kfree(ks8995);
 
 	return 0;
Signature · 1 line
1.7.10.4