Skip to contentSkip to conversation

pinctrl: samsung: remove duplicated line of samsung_pinctrl_register()

PATCH In review Jingoo Han 4 participants 4 messages Feb 8, 2013 – Feb 10, 2013

Subsystems (2)
lore
Share & tools
lore

Jingoo Han

author
#0 lore raw

PATCH 1/1 pinctrl: samsung: remove duplicated line of samsung_pinctrl_register()

This patch removes duplicated line of samsung_pinctrl_register(), because the number of pins is redundantly assigned twice.

---
 drivers/pinctrl/pinctrl-samsung.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/pinctrl/pinctrl-samsung.c +0 -1
index 294bcdd..3d5cf63 100644
@@ -716,7 +716,6 @@ static int samsung_pinctrl_register(struct platform_device *pdev,
 	}
 	ctrldesc->pins = pindesc;
 	ctrldesc->npins = drvdata->ctrl->nr_pins;
-	ctrldesc->npins = drvdata->ctrl->nr_pins;
 
 	/* dynamically populate the pin number and pin name for pindesc */
 	for (pin = 0, pdesc = pindesc; pin < ctrldesc->npins; pin++, pdesc++)
Signature · 1 line
1.7.2.5
Reviewed-by on v1 1/1
#1 lore raw
Quoted 13 lines · On Friday 08 of February 2013 14:39:30 Jingoo Han wrote:

This patch removes duplicated line of samsung_pinctrl_register(), because the number of pins is redundantly assigned twice.

---
 drivers/pinctrl/pinctrl-samsung.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
(quoted diff) +0 -0

b/drivers/pinctrl/pinctrl-samsung.c index 294bcdd..3d5cf63 100644

drivers/pinctrl/pinctrl-samsung.c static int samsung_pinctrl_register(struct · line 721

Quoted 7 lines
drivers/pinctrl/pinctrl-samsung.c +0 -1
@@ -716,7 +716,6 @@ static int samsung_pinctrl_register(struct
 platform_device *pdev, }
 	ctrldesc->pins = pindesc;
 	ctrldesc->npins = drvdata->ctrl->nr_pins;
-	ctrldesc->npins = drvdata->ctrl->nr_pins;
 
 	/* dynamically populate the pin number and pin name for pindesc */
 	for (pin = 0, pdesc = pindesc; pin < ctrldesc->npins; pin++, 

pdesc++)

Best regards,

Signature · 3 lines
Tomasz Figa
Samsung Poland R&D Center
SW Solution Development, Linux Platform
Acked-by on v1 1/1
#2 lore raw
In reply to Jingoo Han
Quoted 5 lines · Jingoo Han

This patch removes duplicated line of samsung_pinctrl_register(), because the number of pins is redundantly assigned twice.

Thanks.

- Kukjin

Quoted 17 lines
---
 drivers/pinctrl/pinctrl-samsung.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/pinctrl/pinctrl- renamed from drivers/pinctrl/pinctrl-samsung.c +0 -0

samsung.c
index 294bcdd..3d5cf63 100644

drivers/pinctrl/pinctrl-samsung.c +0 -1
@@ -716,7 +716,6 @@ static int samsung_pinctrl_register(struct
 platform_device *pdev,
 	}
 	ctrldesc->pins = pindesc;
 	ctrldesc->npins = drvdata->ctrl->nr_pins;
-	ctrldesc->npins = drvdata->ctrl->nr_pins;
 
 	/* dynamically populate the pin number and pin name for pindesc */
Quoted 1 line

for (pin = 0, pdesc = pindesc; pin < ctrldesc->npins; pin++,

pdesc++)

Quoted 2 lines

--
1.7.2.5