gpio: rdc321x: remove unnecessary platform_set_drvdata()
PATCH 3/7 gpio: rdc321x: remove unnecessary platform_set_drvdata()
The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.
Signed-off-by Jingoo Han <[email protected]>
--- drivers/gpio/gpio-rdc321x.c | 7 ++----- 1 files changed, 2 insertions(+), 5 deletions(-)
drivers/gpio/gpio-rdc321x.c +2 -5
@@ -187,20 +187,18 @@ static int rdc321x_gpio_probe(struct platform_device *pdev) rdc321x_gpio_dev->reg1_data_base, &rdc321x_gpio_dev->data_reg[0]);if (err) - goto out_drvdata; + goto out_free; err =pci_read_config_dword (rdc321x_gpio_dev->sb_pdev, rdc321x_gpio_dev->reg2_data_base, &rdc321x_gpio_dev->data_reg[1 ]);if (err) - goto out_drvdata; + goto out_free;dev_info (&pdev->dev,"registering %d GPIOs\n" , rdc321x_gpio_dev->chip.ngpio);return gpiochip_add (&rdc321x_gpio_dev->chip); -out_drvdata: -platform_set_drvdata (pdev,NULL ); out_free:kfree (rdc321x_gpio_dev);return err;
@@ -216,7 +214,6 @@ static int rdc321x_gpio_remove(struct platform_device *pdev)dev_err (&pdev->dev,"failed to unregister chip\n" );kfree (rdc321x_gpio_dev); -platform_set_drvdata (pdev,NULL );return ret; }
Signature · 1 line
1.7.2.5
Quoted 6 lines · Jingoo Han
The driver core clears the driver data to NULL after
device_releaseor on probe failure, since commit0998d0631001288a5974afc0b2a5f568bcdecb4d(device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.Signed-off-by Jingoo Han <[email protected]>
Patch applied.
Yours,
Linus Walleij