selinux: move pkey sid cache based retrieval under defconfig
PATCH 1/1 selinux: move pkey sid cache based retrieval under defconfig
Hi Team,
We see an increase in the memory consumption from 4.9 ->4.19 kernel which is impacting the low_ram device .
So thought of enabling only that are really needed for the such device where performance might not be of priority list .
One such patch is on the pkey sid cache which was added with commit :" 409dcf31"
which can be moved under defconfig where enabled by default and only disabled for low_ram targets.
Which is going to save ram/reduce slub usage .
--
From 1719256bbb8fe3e239be0928386a50b7b41752e8 Mon Sep 17 00:00:00 2001
From: Ravi Kumar Siddojigari <[email protected]>
Date: Wed, 11 Dec 2019 19:57:24 +0530
Subject: [PATCH] selinux: move pkey sid cache based retrieval under defconfig
.
adding new key CONFIG_FASTER_RETRIEVAL_PKEY_SID which is used to enable cache based pkey sid retrieval code added with Commit 409dcf31. As this is going to alloc a new cache for this booster which may impact low ram devices . By default its enabled for low_ram targets they can disable this feature.
--- security/selinux/Kconfig | 10 ++++++++++ security/selinux/Makefile | 4 +++- security/selinux/hooks.c | 10 ++++++++++ security/selinux/include/objsec.h | 2 ++ 4 files changed, 25 insertions(+), 4 deletions(-)
security/selinux/Kconfig +10 -0
@@ -99,3 +99,13 @@ config SECURITY_SELINUX_CHECKREQPROT_VALUE via /selinux/checkreqprot if authorized by policy. If you are unsure how to answer this question, answer 0. + +config FASTER_RETRIEVAL_PKEY_SID + bool "quicker retrieval of PKey SIDs" + depends on SECURITY_SELINUX + default y + help + This option enables cache for quicker retrieval of PKey SIDs + by storing the Pkey SIDs to cache. + Better performance but penalty on memory (RAM ). + for low ram devices better to say n.
security/selinux/Makefile +1 -1
@@ -6,12 +6,14 @@ obj-$(CONFIG_SECURITY_SELINUX) := selinux.o selinux-y := avc.o hooks.o selinuxfs.o netlink.o nlmsgtab.o netif.o \ - netnode.o netport.o ibpkey.o exports.o \ + netnode.o netport.o exports.o \ ss/ebitmap.o ss/hashtab.o ss/symtab.o ss/sidtab.o ss/avtab.o \ ss/policydb.o ss/services.o ss/conditional.o ss/mls.o
ss/status.o
selinux-$(CONFIG_SECURITY_NETWORK_XFRM) += xfrm.o
+selinux-$(CONFIG_FASTER_RETRIEVAL_PKEY_SID) += ibpkey.o +
selinux-$(CONFIG_NETLABEL) += netlabel.o
ccflags-y := -I$(srctree)/security/selinux
-I$(srctree)/security/selinux/include
security/selinux/hooks.c +6 -0
@@ -92,7 +92,11 @@#include "netif.h" #include "netnode.h" #include "netport.h" + +#ifdef CONFIG_FASTER_RETRIEVAL_PKEY_SID #include "ibpkey.h" +#endif +#include "xfrm.h" #include "netlabel.h" #include "audit.h"
@@ -177,7 +181,9 @@ static int selinux_netcache_avc_callback(u32 event)static int selinux_lsm_notifier_avc_callback (u32 event) {if (event ==AVC_CALLBACK_RESET ) { +#ifdef CONFIG_FASTER_RETRIEVAL_PKEY_SID sel_ib_pkey_flush (); +#endif call_lsm_notifier (LSM_POLICY_CHANGE ,NULL ); }
@@ -6246,7 +6252,11 @@ static int selinux_ib_pkey_access(void *ib_sec, u64
subnet_prefix, u16 pkey_val)
struct ib_security_struct *sec = ib_sec;
struct lsm_ibpkey_audit ibpkey;
+#ifdef CONFIG_FASTER_RETRIEVAL_PKEY_SID
err = sel_ib_pkey_sid(subnet_prefix, pkey_val, &sid);
+#else
+ err = security_ib_pkey_sid(subnet_prefix, pkey_val, &sid);
+#endif
if (err)
return err;
(quoted diff) +0 -0
b/security/selinux/include/objsec.h
index 9cec304..5608978 100644
security/selinux/include/objsec.h +2 -0
@@ -147,11 +147,13 @@ struct ib_security_struct {u32 sid;/* SID of the queue pair or MAD agent */ }; +#ifdef CONFIG_FASTER_RETRIEVAL_PKEY_SID struct pkey_security_struct {u64 subnet_prefix;/* Port subnet prefix */ u16 pkey;/* PKey number */ u32 sid;/* SID of pkey */ }; +#endif struct bpf_security_struct {u32 sid;/*SID of bpf obj creater*/
Signature · 4 lines
1.9.1 Regards, Ravi
Paul Moore
maintainerQuoted 10 lines · Ravi Kumar Siddojigari
Hi Team,
We see an increase in the memory consumption from 4.9 ->4.19 kernel which is impacting thelow_ramdevice .
So thought of enabling only that are really needed for the such device where performance might not be of priority list .
One such patch is on the pkey sid cache which was added with commit :"409dcf31"
which can be moved under defconfig where enabled by default and only disabled forlow_ramtargets.
Which is going to save ram/reduce slub usage .
Why not just reuse CONFIG_SECURITY_INFINIBAND? I'm guessing these systems are using the SELinux/IB controls at all, so why not remove them completely?
Signature · 2 lines
paul moore www.paul-moore.com
Yes Paul, it should be under CONFIG_SECURITY_INFINIBAND thanks for correcting this . Hope we can taken it fwd as all the targets with disabled InfiniBand can be gained . Please find the updated path for review .
From 6a8c60eacd0b6e5189722bb1823864b6728c2e34 Mon Sep 17 00:00:00 2001
From: Ravi Kumar Siddojigari <[email protected]>
Date: Wed, 11 Dec 2019 19:57:24 +0530
Subject: [PATCH] selinux: move ibpkeys code under CONFIG_SECURITY_INFINIBAND.
Move cache based pkey sid retrieval code which was added with Commit 409dcf31. under CONFIG_SECURITY_INFINIBAND. As its going to alloc a new cache which may impact low ram devices which was enabled by default.
--- security/selinux/Makefile | 4 +++- security/selinux/hooks.c | 6 ++++++ security/selinux/include/objsec.h | 2 ++ 3 files changed, 11 insertions(+), 1 deletion(-)
security/selinux/Makefile +3 -1
@@ -6,12 +6,14 @@ obj-$(CONFIG_SECURITY_SELINUX) := selinux.o selinux-y := avc.o hooks.o selinuxfs.o netlink.o nlmsgtab.o netif.o \ - netnode.o netport.o ibpkey.o exports.o \ + netnode.o netport.o exports.o \ ss/ebitmap.o ss/hashtab.o ss/symtab.o ss/sidtab.o ss/avtab.o \ ss/policydb.o ss/services.o ss/conditional.o ss/mls.o ss/status.o selinux-$(CONFIG_SECURITY_NETWORK_XFRM) += xfrm.o +selinux-$(CONFIG_SECURITY_INFINIBAND) += ibpkey.o + selinux-$(CONFIG_NETLABEL) += netlabel.o ccflags-y := -I$(srctree)/security/selinux -I$(srctree)/security/selinux/include
security/selinux/hooks.c +6 -0
@@ -94,7 +94,11 @@#include "netif.h" #include "netnode.h" #include "netport.h" + +#ifdef CONFIG_SECURITY_INFINIBAND #include "ibpkey.h" +#endif +#include "xfrm.h" #include "netlabel.h" #include "audit.h"
@@ -198,7 +202,9 @@ static int selinux_netcache_avc_callback(u32 event)static int selinux_lsm_notifier_avc_callback (u32 event) {if (event ==AVC_CALLBACK_RESET ) { +#ifdef CONFIG_SECURITY_INFINIBAND sel_ib_pkey_flush (); +#endif call_lsm_notifier (LSM_POLICY_CHANGE ,NULL ); }
security/selinux/include/objsec.h +2 -0
@@ -149,11 +149,13 @@ struct ib_security_struct {u32 sid;/* SID of the queue pair or MAD agent */ }; +#ifdef CONFIG_SECURITY_INFINIBAND struct pkey_security_struct {u64 subnet_prefix;/* Port subnet prefix */ u16 pkey;/* PKey number */ u32 sid;/* SID of pkey */ }; +#endif struct bpf_security_struct {u32 sid;/*SID of bpf obj creater*/
Signature · 5 lines
1.9.1 Regards, Ravi
-----Original Message-----
From: [email protected] <[email protected]> On Behalf Of Paul Moore
Sent: Monday, December 16, 2019 7:56 PM
To: Ravi Kumar Siddojigari <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH] selinux: move pkey sid cache based retrieval under defconfig
Quoted 10 lines · Ravi Kumar Siddojigari
Hi Team,
We see an increase in the memory consumption from 4.9 ->4.19 kernel which is impacting thelow_ramdevice .
So thought of enabling only that are really needed for the such device where performance might not be of priority list .
One such patch is on the pkey sid cache which was added with commit :"409dcf31"
which can be moved under defconfig where enabled by default and only disabled forlow_ramtargets.
Which is going to save ram/reduce slub usage .
Why not just reuse CONFIG_SECURITY_INFINIBAND? I'm guessing these systems are using the SELinux/IB controls at all, so why not remove them completely?
--
paul moore
www.paul-moore.com