net: ethernet: cirrus: remove unnecessary platform_set_drvdata()
Subsystems (3)
PATCH 11/36 net: ethernet: cirrus: remove unnecessary platform_set_drvdata()
The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.
Signed-off-by Jingoo Han <[email protected]>
--- drivers/net/ethernet/cirrus/ep93xx_eth.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/net/ethernet/cirrus/ep93xx_eth.c +0 -1
@@ -783,7 +783,6 @@ static int ep93xx_eth_remove(struct platform_device *pdev) dev =platform_get_drvdata (pdev);if (dev ==NULL )return 0 ; -platform_set_drvdata (pdev,NULL ); ep =netdev_priv (dev);
Signature · 1 line
1.7.2.5
Quoted 9 lines · Jingoo Han
The driver core clears the driver data to NULL after
device_releaseor on probe failure, since commit0998d0631001288a5974afc0b2a5f568bcdecb4d(device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.Signed-off-by Jingoo Han <[email protected]>--- drivers/net/ethernet/cirrus/ep93xx_eth.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)
Reviewed-by H Hartley Sweeten <[email protected]>