hwmon: (emc6w201) Staticize enum 'subfeature'
PATCH 1/1 hwmon: (emc6w201) Staticize enum 'subfeature'
The enum 'subfeature' is used only in this file.
Fix the following sparse warning:
drivers/hwmon/emc6w201.c:52:26: warning: symbol 'subfeature' was not declared. Should it be static?
Signed-off-by Jingoo Han <[email protected]>
--- drivers/hwmon/emc6w201.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/hwmon/emc6w201.c +1 -1
@@ -49,7 +49,7 @@ static const unsigned short normal_i2c[] = { 0x2c, 0x2d, 0x2e, I2C_CLIENT_END };#define EMC6W201_REG_TEMP_HIGH (nr) (0x57 + (nr) * 2)#define EMC6W201_REG_FAN_MIN (nr) (0x62 + (nr) * 2) -enum { input, min, max } subfeature; +static enum { input, min, max } subfeature;/* * Per-device data
Signature · 8 lines
1.7.10.4 _______________________________________________ lm-sensors mailing list [email protected] http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
Hi Jingoo,
Quoted 15 lines · Jingoo Han
The enum 'subfeature' is used only in this file.
Fix the following sparse warning:
drivers/hwmon/emc6w201.c:52:26: warning: symbol 'subfeature' was not declared. Should it be static?Signed-off-by Jingoo Han <[email protected]>--- drivers/hwmon/emc6w201.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/hwmon/emc6w201.c +0
-0
drivers/hwmon/emc6w201.c static const unsigned short normal_i2c[] = { 0x2c, 0x2d, 0x2e, I2C_CLIENT_END }; · line 55
Quoted 8 lines
drivers/hwmon/emc6w201.c +1
-1@@ -49,7 +49,7 @@ static const unsigned short normal_i2c[] = { 0x2c, 0x2d, 0x2e, I2C_CLIENT_END };#define EMC6W201_REG_TEMP_HIGH (nr) (0x57 + (nr) * 2)#define EMC6W201_REG_FAN_MIN (nr) (0x62 + (nr) * 2) -enum { input, min, max } subfeature; +static enum { input, min, max } subfeature;/* * Per-device data
A better fixed has already been submitted by Guenter Roeck:
http://lists.lm-sensors.org/pipermail/lm-sensors/2013-August/039599.html
The variable is not needed at all.
Thanks anyway,
Signature · 6 lines
Jean Delvare _______________________________________________ lm-sensors mailing list [email protected] http://lists.lm-sensors.org/mailman/listinfo/lm-sensors