Skip to contentSkip to conversation

pinctrl: coh901: remove unnecessary platform_set_drvdata()

PATCH In review Jingoo Han 2 participants 2 messages May 6, 2013 – May 14, 2013 Pin control

lore
Share & tools
lore

Jingoo Han

author
#0 lore raw

PATCH 1/4 pinctrl: coh901: remove unnecessary platform_set_drvdata()

The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.

---
 drivers/pinctrl/pinctrl-coh901.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/pinctrl/pinctrl-coh901.c +0 -1
index edde3ac..f12546b 100644
@@ -860,7 +860,6 @@ static int __exit u300_gpio_remove(struct platform_device *pdev)
 	}
 	u300_gpio_free_ports(gpio);
 	clk_disable_unprepare(gpio->clk);
-	platform_set_drvdata(pdev, NULL);
 	return 0;
 }
 
Signature · 1 line
1.7.2.5
#1 lore raw
Quoted 6 lines · Jingoo Han

The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.

Patch applied.

Thanks!
Linus Walleij