Skip to contentSkip to conversation

pwm: core: use seq_puts() instead of seq_printf()

PATCH In review Jingoo Han 2 participants 4 messages Dec 19, 2013 – Dec 20, 2013 PWM

lore
Share & tools
lore

Jingoo Han

author
#0 lore raw

PATCH 1/3 pwm: core: use seq_puts() instead of seq_printf()

For a constant format without additional arguments, use seq_puts() instead of seq_printf(). Also, the following checkpatch warning is fixed.

WARNING: Prefer seq_puts to seq_printf

---
 drivers/pwm/core.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/pwm/core.c +3 -3
index 2ca9504..a804713 100644
@@ -808,12 +808,12 @@ static void pwm_dbg_show(struct pwm_chip *chip, struct seq_file *s)
 		seq_printf(s, " pwm-%-3d (%-20.20s):", i, pwm->label);
 
 		if (test_bit(PWMF_REQUESTED, &pwm->flags))
-			seq_printf(s, " requested");
+			seq_puts(s, " requested");
 
 		if (test_bit(PWMF_ENABLED, &pwm->flags))
-			seq_printf(s, " enabled");
+			seq_puts(s, " enabled");
 
-		seq_printf(s, "\n");
+		seq_puts(s, "\n");
 	}
 }
 
Signature · 1 line
1.7.10.4
author
#1 lore raw

PATCH 2/3 pwm: pwm-ep93xx: split module author names

Split module author names in order to fix the following checkpatch warning.

WARNING: quoted string split across lines

---
 drivers/pwm/pwm-ep93xx.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/pwm/pwm-ep93xx.c +2 -2
index 33aa446..e593e9c 100644
@@ -224,7 +224,7 @@ static struct platform_driver ep93xx_pwm_driver = {
 module_platform_driver(ep93xx_pwm_driver);
 
 MODULE_DESCRIPTION("Cirrus Logic EP93xx PWM driver");
-MODULE_AUTHOR("Matthieu Crapet <[email protected]>, "
-	      "H Hartley Sweeten <[email protected]>");
+MODULE_AUTHOR("Matthieu Crapet <[email protected]>");
+MODULE_AUTHOR("H Hartley Sweeten <[email protected]>");
 MODULE_ALIAS("platform:ep93xx-pwm");
 MODULE_LICENSE("GPL");
Signature · 1 line
1.7.10.4
author
#2 lore raw

PATCH 3/3 pwm: pxa: remove unnecessary space before tabs

In reply to Jingoo Han

Remove unnecessary space before tabs in order to fix the following checkpatch warning.

WARNING: please, no space before tabs

---
 drivers/pwm/pwm-pxa.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pwm/pwm-pxa.c +1 -1
index 3dc7c10..8d99573 100644
@@ -8,7 +8,7 @@
  * published by the Free Software Foundation.
  *
  * 2008-02-13	initial version
- * 		eric miao <[email protected]>
+ *		eric miao <[email protected]>
  */
 
 #include <linux/module.h>
Signature · 1 line
1.7.10.4
#3 lore raw
In reply to Jingoo Han
Quoted 10 lines · Jingoo Han

For a constant format without additional arguments, use seq_puts() instead of seq_printf(). Also, the following checkpatch warning is fixed.

WARNING: Prefer seq_puts to seq_printf

---
 drivers/pwm/core.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

All three patches applied, thanks!

Thierry