Skip to contentSkip to conversation

Add definitions of keypad register

PATCH New 양진성 2 participants 4 messages Sep 5, 2009 – Sep 7, 2009

Subsystems (2)
lore
Share & tools
lore

양진성

author
#0 lore raw

PATCH 9/12 Add definitions of keypad register

This patch supports register map for s3c keypad driver.

---
 arch/arm/plat-s3c/include/plat/regs-keypad.h |   39 ++++++++++++++++++++++++++
 1 files changed, 39 insertions(+), 0 deletions(-)
 create mode 100644 arch/arm/plat-s3c/include/plat/regs-keypad.h
arch/arm/plat-s3c/include/plat/regs-keypad.h new file +39 -0
new file mode 100644
index 0000000..ca71ecb
@@ -0,0 +1,39 @@
+/* linux/arch/arm/plat-s3c/include/plat/regs-keypad.h
+ *
+ * S3C Key Interface register definitions
+ *
+ * Kim Kyoungil, Copyright (c) 2006-2009 Samsung Electronics
+ *      http://www.samsungsemi.com/
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+
+
+#ifndef __ASM_ARCH_REGS_KEYPAD_H
+#define __ASM_ARCH_REGS_KEYPAD_H
+
+/* 
+ * Keypad Interface
+ */
+#define S3C_KEYPADREG(x)	(x)
+
+#define S3C_KEYIFCON		S3C_KEYPADREG(0x00)
+#define S3C_KEYIFSTSCLR		S3C_KEYPADREG(0x04)
+#define S3C_KEYIFCOL		S3C_KEYPADREG(0x08)
+#define S3C_KEYIFROW		S3C_KEYPADREG(0x0C)
+#define S3C_KEYIFFC		S3C_KEYPADREG(0x10)
+
+#define S3C_KEYIF_COL_DMASK	(0xff)
+#define S3C_KEYIF_ROW_DMASK	(0xff)
+#define S3C_KEYIF_INT_F_EN	(1 << 0) /*falling edge(key-pressed) interuppt enable*/
+#define S3C_KEYIF_INT_R_EN	(1 << 1) /*rising edge(key-released) interuppt enable*/
+#define S3C_KEYIF_DF_EN		(1 << 2) /*debouncing filter enable*/
+#define S3C_KEYIF_FC_EN		(1 << 3) /*filter clock enable*/
+#define S3C_KEYIF_CON_MASK_ALL	(0x1f)
+#define S3C_KEYIF_COL_MASK_ALL	(0xffff)
+#define S3C_KEYIF_STSCLR_CLEAR	(0xffff)
+
+#endif /* __ASM_ARCH_REGS_KEYPAD_H */
+
Signature · 1 line
1.6.2.5
#1 lore raw

PATCH 9/12 Add definitions of keypad register

2009/9/5 ??? <[email protected]>:

Quoted 41 lines

This patch supports register map for s3c keypad driver.

---
?arch/arm/plat-s3c/include/plat/regs-keypad.h | ? 39 ++++++++++++++++++++++++++ ?1 files changed, 39 insertions(+), 0 deletions(-)
?create mode 100644 arch/arm/plat-s3c/include/plat/regs-keypad.h

arch/arm/plat-s3c/include/plat/regs-keypad.h new file +26 -0
new file mode 100644
index 0000000..ca71ecb
@@ -0,0 +1,39 @@
+/* linux/arch/arm/plat-s3c/include/plat/regs-keypad.h
+ *
+ * S3C Key Interface register definitions
+ *
+ * Kim Kyoungil, Copyright (c) 2006-2009 Samsung Electronics
+ * ? ? ?http://www.samsungsemi.com/
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+
+
+#ifndef __ASM_ARCH_REGS_KEYPAD_H
+#define __ASM_ARCH_REGS_KEYPAD_H
+
+/*
+ * Keypad Interface
+ */
+#define S3C_KEYPADREG(x) ? ? ? (x)
+
+#define S3C_KEYIFCON ? ? ? ? ? S3C_KEYPADREG(0x00)
+#define S3C_KEYIFSTSCLR ? ? ? ? ? ? ? ?S3C_KEYPADREG(0x04)
+#define S3C_KEYIFCOL ? ? ? ? ? S3C_KEYPADREG(0x08)
+#define S3C_KEYIFROW ? ? ? ? ? S3C_KEYPADREG(0x0C)
+#define S3C_KEYIFFC ? ? ? ? ? ?S3C_KEYPADREG(0x10)

arch/arm/plat-s3c/include/plat/regs-keypad.h line 36

Quoted 10 lines
arch/arm/plat-s3c/include/plat/regs-keypad.h new file +10 -0
+
+#define S3C_KEYIF_COL_DMASK ? ?(0xff)
+#define S3C_KEYIF_ROW_DMASK ? ?(0xff)
+#define S3C_KEYIF_INT_F_EN ? ? (1 << 0) /*falling edge(key-pressed) interuppt enable*/
+#define S3C_KEYIF_INT_R_EN ? ? (1 << 1) /*rising edge(key-released) interuppt enable*/
+#define S3C_KEYIF_DF_EN ? ? ? ? ? ? ? ?(1 << 2) /*debouncing filter enable*/
+#define S3C_KEYIF_FC_EN ? ? ? ? ? ? ? ?(1 << 3) /*filter clock enable*/
+#define S3C_KEYIF_CON_MASK_ALL (0x1f)
+#define S3C_KEYIF_COL_MASK_ALL (0xffff)
+#define S3C_KEYIF_STSCLR_CLEAR (0xffff)

Can you re-organize it as each register. I mean KEYIFCON fileds first, KEYIFSTRCLR files second and so on.

Can't figure out well

Thank you,
Kyungmin Park

Quoted 12 lines
arch/arm/plat-s3c/include/plat/regs-keypad.h new file +3 -1
+
+#endif /* __ASM_ARCH_REGS_KEYPAD_H */
+
--

1.6.2.5

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#2 lore raw

PATCH 9/12 Add definitions of keypad register

Hi,

Quoted 5 lines

Can you re-organize it as each register. I mean KEYIFCON fileds first, KEYIFSTRCLR files second and so on.

Can't figure out well

I'm not sure what you tell me about..
Do you mean something like that?

#define REG1
#define REG1_FIELD1
#define REG1_FIELD2

#define REG2
#define REG2_FIELD1
#define REG2_FIELD2

#define REG3
#define REG3_FIELD1
#define REG3_FIELD2

Or like this?
#define REG1
#define REG2
#define REG3

#define REG1_FIELD1
#define REG1_FIELD2
#define REG2_FIELD1
#define REG2_FIELD2
#define REG3_FIELD1
#define REG3_FIELD2

#3 lore raw

PATCH 9/12 Add definitions of keypad register

Quoted 28 lines · Jinsung Yang

Hi,

Quoted 5 lines

Can you re-organize it as each register. I mean KEYIFCON fileds first, KEYIFSTRCLR files second and so on.

Can't figure out well

I'm not sure what you tell me about..
Do you mean something like that?

#define REG1
#define REG1_FIELD1
#define REG1_FIELD2

#define REG2
#define REG2_FIELD1
#define REG2_FIELD2

#define REG3
#define REG3_FIELD1
#define REG3_FIELD2

Or like this?
#define REG1
#define REG2
#define REG3

Quoted 7 lines

#define REG1_FIELD1
#define REG1_FIELD2
#define REG2_FIELD1
#define REG2_FIELD2
#define REG3_FIELD1
#define REG3_FIELD2

latter

#define REG1_OFFSET
#define REG2_OFFSET
#define REG3_OFFSET

/* REG1 field */
#define REG1_FIELD1
#define REG1_FIELD2

/* REG2 field */
#define REG2_FIELD1
#define REG2_FIELD2

/* REG3 field */
#define REG3_FIELD1
#define REG3_FIELD2

How about to review the another keypad drivers?

Thank you,
Kyungmin Park