Skip to contentSkip to conversation

ARM: dts: Fix gpio pin of lcd_en node for exynos4210

PATCH In review Jingoo Han 2 participants 5 messages Sep 3, 2013

Subsystems (2)
lore
Share & tools
lore

Jingoo Han

author
#0 lore raw

PATCH 1/1 ARM: dts: Fix gpio pin of lcd_en node for exynos4210

According to datasheet, 'lcd_en' node should use gpf0-2, instead of gpe3-4. gpe3-4 is used for MDM_DATA[4]; thus, it should be fixed.

---
 arch/arm/boot/dts/exynos4210-pinctrl.dtsi |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/exynos4210-pinctrl.dtsi +1 -1
index a7c2128..da5dd8d 100644
@@ -374,7 +374,7 @@
 		};
 
 		lcd_en: lcd-en {
-			samsung,pins = "gpe3-4";
+			samsung,pins = "gpf0-2";
 			samsung,pin-function = <2>;
 			samsung,pin-pud = <0>;
 			samsung,pin-drv = <0>;
Signature · 1 line
1.7.10.4
#1 lore raw
Quoted 14 lines · Jingoo Han

According to datasheet, 'lcd_en' node should use gpf0-2, instead of gpe3-4. gpe3-4 is used for MDM_DATA[4]; thus, it should be fixed.

---
 arch/arm/boot/dts/exynos4210-pinctrl.dtsi |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/exynos4210-pinctrl.dtsi +0 -0
index a7c2128..da5dd8d 100644

arch/arm/boot/dts/exynos4210-pinctrl.dtsi line 380

Quoted 8 lines
arch/arm/boot/dts/exynos4210-pinctrl.dtsi +1 -1
@@ -374,7 +374,7 @@
                };
 
                lcd_en: lcd-en {
-                       samsung,pins = "gpe3-4";
+                       samsung,pins = "gpf0-2";
                        samsung,pin-function = <2>;
                        samsung,pin-pud = <0>;
                        samsung,pin-drv = <0>;

With this change, the LCD display stops working on Origen board.

gpf0-{0,1,2,3} are defined under lcd_clk.

Signature · 1 line
Tushar Behera
author
#2 lore raw
Quoted 17 lines · Tushar Behera
Quoted 16 lines · Jingoo Han

According to datasheet, 'lcd_en' node should use gpf0-2, instead of gpe3-4. gpe3-4 is used for MDM_DATA[4]; thus, it should be fixed.

---
 arch/arm/boot/dts/exynos4210-pinctrl.dtsi |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/exynos4210-pinctrl.dtsi +0 -0
index a7c2128..da5dd8d 100644
@@ -374,7 +374,7 @@
                };
 
Quoted 8 lines

arch/arm/boot/dts/exynos4210-pinctrl.dtsi line 380

Quoted 6 lines
arch/arm/boot/dts/exynos4210-pinctrl.dtsi +1 -1
                lcd_en: lcd-en {
-                       samsung,pins = "gpe3-4";
+                       samsung,pins = "gpf0-2";
                        samsung,pin-function = <2>;
                        samsung,pin-pud = <0>;
                        samsung,pin-drv = <0>;

With this change, the LCD display stops working on Origen board.

The smdkv310 board worked properly.
gpe3-4 seems to be necessary for Origen board. Can you describe why gpe3-4 is necessary for Origen board?

According to the datasheet, pin-function of gpe3-4 is defined as MDM_DATA[4]. So, the node name 'lcd_en' is wrong or confusing.

Quoted 2 lines

gpf0-{0,1,2,3} are defined under lcd_clk.

Then will you test the following on Origen board?

+++ b/arch/arm/boot/dts/exynos4210-origen.dts
@@ -293,7 +293,7 @@

        };

        fimd@11c00000 {

- pinctrl-0 = <&lcd_en &lcd_clk &lcd_data24 &pwm0_out>;
+ pinctrl-0 = <&lcd_clk &lcd_data24 &pwm0_out>;

Best regards,
Jingoo Han

#3 lore raw
Quoted 27 lines · Jingoo Han
Quoted 17 lines · Tushar Behera
Quoted 16 lines · Jingoo Han

According to datasheet, 'lcd_en' node should use gpf0-2, instead of gpe3-4. gpe3-4 is used for MDM_DATA[4]; thus, it should be fixed.

---
 arch/arm/boot/dts/exynos4210-pinctrl.dtsi |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/exynos4210-pinctrl.dtsi +0 -0
index a7c2128..da5dd8d 100644
@@ -374,7 +374,7 @@
                };
 
Quoted 8 lines

arch/arm/boot/dts/exynos4210-pinctrl.dtsi line 380

Quoted 6 lines
arch/arm/boot/dts/exynos4210-pinctrl.dtsi +1 -1
                lcd_en: lcd-en {
-                       samsung,pins = "gpe3-4";
+                       samsung,pins = "gpf0-2";
                        samsung,pin-function = <2>;
                        samsung,pin-pud = <0>;
                        samsung,pin-drv = <0>;

With this change, the LCD display stops working on Origen board.

Quoted 4 lines

The smdkv310 board worked properly.
gpe3-4 seems to be necessary for Origen board. Can you describe why gpe3-4 is necessary for Origen board?

Without setting this pin, LCD panel doesn't power up. It is quite possible that this is Origen specific. In that case, how do you suggest to implement this for Origen board?

Quoted 10 lines

According to the datasheet, pin-function of gpe3-4 is defined as MDM_DATA[4]. So, the node name 'lcd_en' is wrong or confusing.

Quoted 2 lines

gpf0-{0,1,2,3} are defined under lcd_clk.

Then will you test the following on Origen board?

+++ b/arch/arm/boot/dts/exynos4210-origen.dts

Review line 297

Quoted 6 lines
(quoted diff) +1 -1
@@ -293,7 +293,7 @@
        };
 
        fimd@11c00000 {
-               pinctrl-0 = <&lcd_en &lcd_clk &lcd_data24 &pwm0_out>;
+               pinctrl-0 = <&lcd_clk &lcd_data24 &pwm0_out>;
 

No, this doesn't work on Origen.

Signature · 1 line
Tushar Behera
author
#4 lore raw
Quoted 29 lines · Tushar Behera
Quoted 6 lines · Jingoo Han
Quoted 5 lines · Tushar Behera
Quoted 4 lines · Jingoo Han

According to datasheet, 'lcd_en' node should use gpf0-2, instead of gpe3-4. gpe3-4 is used for MDM_DATA[4]; thus, it should be fixed.

Quoted 6 lines
Quoted 6 lines

arch/arm/boot/dts/exynos4210-

Quoted 6 lines
---
 arch/arm/boot/dts/exynos4210-pinctrl.dtsi |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/exynos4210- renamed from arch/arm/boot/dts/exynos4210-pinctrl.dtsi +0 -0

pinctrl.dtsi

Quoted 15 lines
Quoted 14 lines

arch/arm/boot/dts/exynos4210-pinctrl.dtsi line 380

Quoted 12 lines

index a7c2128..da5dd8d 100644

arch/arm/boot/dts/exynos4210-pinctrl.dtsi +1 -1
@@ -374,7 +374,7 @@
                };
 
                lcd_en: lcd-en {
-                       samsung,pins = "gpe3-4";
+                       samsung,pins = "gpf0-2";
                        samsung,pin-function = <2>;
                        samsung,pin-pud = <0>;
                        samsung,pin-drv = <0>;

With this change, the LCD display stops working on Origen board.

Quoted 8 lines
Quoted 4 lines

The smdkv310 board worked properly.
gpe3-4 seems to be necessary for Origen board. Can you describe why gpe3-4 is necessary for Origen board?

Without setting this pin, LCD panel doesn't power up. It is quite possible that this is Origen specific. In that case, how do you suggest to implement this for Origen board?

OK, I see.
'gpe3-4' on Origen board is used as LCD panel reset pin. Then, it should be handled as reset-pin control for LCD panel.

Also, one this is clear.
'gpe3-4' should NOT be used as pin-function <2>, because it means MDM_DATA[4]. MDM_DATA[4] is not related to LCD control. It is a definitely wrong usage.

Best regards,
Jingoo Han