tools/power/x86/intel_pstate_tracer: python minimum version
PATCH 1/1 tools/power/x86/intel_pstate_tracer: python minimum version
From: Doug Smythies <[email protected]>
Change the minimum python version from 2.7 to 3.6. Remove a 2.X backwards compatibility line.
--- .../x86/intel_pstate_tracer/intel_pstate_tracer.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py +5 -5
@@ -1,4 +1,4 @@ -#!/usr/bin/env python +#!/usr/bin/env python3 # SPDX-License-Identifier: GPL-2.0-only # -*- coding: utf-8 -*- #
@@ -11,9 +11,9 @@ then this utility enables and collects trace data for a user specified interval and generates performance plots. Prerequisites: - Python version 2.7.x or higher + Python version 3.6.x or higher gnuplot 5.0 or higher - gnuplot-py 1.8 or higher + phython3-gnuplot 1.8 or higher (Most of the distributions have these required packages. They may be called gnuplot-py, phython-gnuplot or phython3-gnuplot, gnuplot-nox, ... )
@@ -23,7 +23,7 @@ Prerequisites: see print_help(): for Usage and Output details """ -from __future__ import print_function + from datetime import datetime import subprocess import os
@@ -562,7 +562,7 @@ if __name__ == "__main__": # Temporary (or perhaps not) cur_version = sys.version_info - print('python version (should be >= 2.7):') + print('python version (should be >= 3.6):') print(cur_version) # Left as "cleanup" for potential future re-run ability.
--
2.25.1
Quoted 21 lines · Doug Smythies
From: Doug Smythies <[email protected]>
Change the minimum python version from 2.7 to 3.6. Remove a 2.X backwards compatibility line.
Signed-off-by Doug Smythies <[email protected]>--- .../x86/intel_pstate_tracer/intel_pstate_tracer.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py +1
-1@@ -1,4 +1,4 @@ -#!/usr/bin/env python +#!/usr/bin/env python3 # SPDX-License-Identifier: GPL-2.0-only # -*- coding: utf-8 -*- #
tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py then this utility enables and collects trace data for a user specified interval · line 16
Quoted 8 lines
tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py +2
-2@@ -11,9 +11,9 @@ then this utility enables and collects trace data for a user specified interval and generates performance plots. Prerequisites: - Python version 2.7.x or higher + Python version 3.6.x or higher gnuplot 5.0 or higher - gnuplot-py 1.8 or higher + phython3-gnuplot 1.8 or higher
Presumably you mean 'python3-gnuplot'.
tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py then this utility enables and collects trace data for a user specified interval · line 19
Quoted 3 lines
tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py +0
-0(Most of the distributions have these required packages. They may be called gnuplot-py, phython-gnuplot or phython3-gnuplot, gnuplot-nox, ... )
Likewise here too.
Quoted 10 lines
tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py +1
-1@@ -23,7 +23,7 @@ Prerequisites: see print_help(): for Usage and Output details """ -from __future__ import print_function + from datetime import datetime import subprocess import os
tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py if __name__ == "__main__": · line 566
Quoted 6 lines
tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py +1
-1@@ -562,7 +562,7 @@ if __name__ == "__main__": # Temporary (or perhaps not) cur_version = sys.version_info - print('python version (should be >= 2.7):') + print('python version (should be >= 3.6):') print(cur_version)
Is this block printing the version really needed at all? I don't see 'cur_version' used anywhere else in the file.
Quoted 6 lines
tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py +0
-1# Left as "cleanup" for potential future re-run ability. --2.25.1
Quoted 24 lines · On 2023.09.17 17:57 Mario wrote:
Quoted 23 lines · Doug Smythies
From: Doug Smythies <[email protected]>
Change the minimum python version from 2.7 to 3.6. Remove a 2.X backwards compatibility line.
Signed-off-by Doug Smythies <[email protected]>--- .../x86/intel_pstate_tracer/intel_pstate_tracer.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py +1
-1@@ -1,4 +1,4 @@ -#!/usr/bin/env python +#!/usr/bin/env python3 # SPDX-License-Identifier: GPL-2.0-only # -*- coding: utf-8 -*- #@@ -11,9 +11,9 @@ then this utility enables and collects trace data for a user specified interval and generates performance plots.
Quoted 8 lines
tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py then this utility enables and collects trace data for a user specified interval · line 16
Quoted 6 lines
tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py +2
-2Prerequisites: - Python version 2.7.x or higher + Python version 3.6.x or higher gnuplot 5.0 or higher - gnuplot-py 1.8 or higher + phython3-gnuplot 1.8 or higherPresumably you mean 'python3-gnuplot'.
Oh Darn. Yes. I'll send a V2.
Quoted 17 lines
tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py then this utility enables and collects trace data for a user specified interval · line 19
Quoted 3 lines
tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py +0
-0(Most of the distributions have these required packages. They may be called gnuplot-py, phython-gnuplot or phython3-gnuplot, gnuplot-nox, ... )Likewise here too.
Quoted 11 lines
tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py +1
-1@@ -23,7 +23,7 @@ Prerequisites: see print_help(): for Usage and Output details """ -from __future__ import print_function + from datetime import datetime import subprocess import os@@ -562,7 +562,7 @@ if __name__ == "__main__":
Quoted 8 lines
tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py if __name__ == "__main__": · line 566
Quoted 5 lines
tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py +1
-1# Temporary (or perhaps not) cur_version = sys.version_info - print('python version (should be >= 2.7):') + print('python version (should be >= 3.6):') print(cur_version)Is this block printing the version really needed at all? I don't see '
cur_version' used anywhere else in the file.
Well, it is there to make it easy to know what the requirements are and what the actual version is. The minimum version is not enforced.
Quoted 3 lines
Quoted 3 lines
tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py +0
-1# Left as "cleanup" for potential future re-run ability. --2.25.1
PATCH v2 1/1 tools/power/x86/intel_pstate_tracer: python minimum version
In reply to Doug SmythiesFrom: Doug Smythies <[email protected]>
Change the minimum python version from 2.7 to 3.6. Remove a 2.X backwards compatibility line.
---
v1 -> v2: Fix careless typos.
---
.../x86/intel_pstate_tracer/intel_pstate_tracer.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py +5 -5
@@ -1,4 +1,4 @@ -#!/usr/bin/env python +#!/usr/bin/env python3 # SPDX-License-Identifier: GPL-2.0-only # -*- coding: utf-8 -*- #
@@ -11,9 +11,9 @@ then this utility enables and collects trace data for a user specified interval and generates performance plots. Prerequisites: - Python version 2.7.x or higher + Python version 3.6.x or higher gnuplot 5.0 or higher - gnuplot-py 1.8 or higher + python3-gnuplot 1.8 or higher (Most of the distributions have these required packages. They may be called gnuplot-py, python-gnuplot or python3-gnuplot, gnuplot-nox, ... )
@@ -23,7 +23,7 @@ Prerequisites: see print_help(): for Usage and Output details """ -from __future__ import print_function + from datetime import datetime import subprocess import os
@@ -562,7 +562,7 @@ if __name__ == "__main__": # Temporary (or perhaps not) cur_version = sys.version_info - print('python version (should be >= 2.7):') + print('python version (should be >= 3.6):') print(cur_version) # Left as "cleanup" for potential future re-run ability.
--
2.25.1
PATCH v3 1/1 tools/power/x86/intel_pstate_tracer: python minimum version
From: Doug Smythies <[email protected]>
Change the minimum python version from 2.7 to 3.6. Remove a 2.X backwards compatibility line.
---
v2 -> v3: Try to fix mess that was v2.
v1 -> v2: Fix careless typos.
---.../x86/intel_pstate_tracer/intel_pstate_tracer.py | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py +6 -6
@@ -1,4 +1,4 @@ -#!/usr/bin/env python +#!/usr/bin/env python3 # SPDX-License-Identifier: GPL-2.0-only # -*- coding: utf-8 -*- #
@@ -11,11 +11,11 @@ then this utility enables and collects trace data for a user specified interval and generates performance plots. Prerequisites: - Python version 2.7.x or higher + Python version 3.6.x or higher gnuplot 5.0 or higher - gnuplot-py 1.8 or higher + python3-gnuplot 1.8 or higher (Most of the distributions have these required packages. They may be called - gnuplot-py, phython-gnuplot or phython3-gnuplot, gnuplot-nox, ... ) + gnuplot-py, python-gnuplot or python3-gnuplot, gnuplot-nox, ... ) HWP (Hardware P-States are disabled) Kernel config for Linux trace is enabled
@@ -23,7 +23,7 @@ Prerequisites: see print_help(): for Usage and Output details """ -from __future__ import print_function + from datetime import datetime import subprocess import os
@@ -562,7 +562,7 @@ if __name__ == "__main__": # Temporary (or perhaps not) cur_version = sys.version_info - print('python version (should be >= 2.7):') + print('python version (should be >= 3.6):') print(cur_version) # Left as "cleanup" for potential future re-run ability.
--
2.25.1
Quoted 1 line · Doug Smythies
Think somehow one extra new line in email.
Quoted 6 lines
From: Doug Smythies <[email protected]>
Change the minimum python version from 2.7 to 3.6. Remove a 2.X backwards compatibility line.
Signed-off-by Doug Smythies <[email protected]>
Quoted 63 lines
---
v2 -> v3: Try to fix mess that was v2.
v1 -> v2: Fix careless typos.---
.../x86/intel_pstate_tracer/intel_pstate_tracer.py | 12 ++++++----- -1 file changed, 6 insertions(+), 6 deletions(-)diff --git
a/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.pyb/tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.pyindexec3323100e1a..38cfbdcdedb7100755tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py +1
-1@@ -1,4 +1,4 @@ -#!/usr/bin/env python +#!/usr/bin/env python3 # SPDX-License-Identifier: GPL-2.0-only # -*- coding: utf-8 -*- #@@ -11,11 +11,11 @@ then this utility enables and collects trace datafor a user specified interval
and generates performance plots.Prerequisites:
- Python version 2.7.x or higher
+ Python version 3.6.x or higher
gnuplot 5.0 or higher
- gnuplot-py 1.8 or higher
+ python3-gnuplot 1.8 or higher
(Most of the distributions have these required packages. They may be called
- gnuplot-py, phython-gnuplot or phython3-gnuplot, gnuplot-nox, ... )
+ gnuplot-py, python-gnuplot or python3-gnuplot, gnuplot-nox, ... )HWP (Hardware P-States are disabled)
Kernel config for Linux trace is enabledtools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py +0
-0@@ -23,7 +23,7 @@ Prerequisites:see
print_help(): for Usage and Output details"""
tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py +1
-1-from __future__ import print_function +from datetime import datetime
import subprocess
import ostools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py +0
-0@@ -562,7 +562,7 @@ if __name__ == "__main__": # Temporary (or perhaps not)
cur_version= sys.version_info
- print('python version (should be >= 2.7):')
+ print('python version (should be >= 3.6):')
print(cur_version)# Left as "cleanup" for potential future re-run ability. --
2.25.1
Quoted 7 lines · Doug Smythies
From: Doug Smythies <[email protected]>
Change the minimum python version from 2.7 to 3.6. Remove a 2.X backwards compatibility line.
Signed-off-by Doug Smythies <[email protected]>
Quoted 9 lines
---
v2 -> v3: Try to fix mess that was v2.
v1 -> v2: Fix careless typos.---
.../x86/intel_pstate_tracer/intel_pstate_tracer.py| 12 ++++++------1 file changed, 6 insertions(+), 6 deletions(-)
Quoted 47 lines
tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py +6
-7@@ -1,4 +1,4 @@ -#!/usr/bin/env python +#!/usr/bin/env python3 # SPDX-License-Identifier: GPL-2.0-only # -*- coding: utf-8 -*- #@@ -11,11 +11,11 @@ then this utility enables and collects trace data for a user specified interval and generates performance plots. Prerequisites: - Python version 2.7.x or higher + Python version 3.6.x or higher gnuplot 5.0 or higher - gnuplot-py 1.8 or higher + python3-gnuplot 1.8 or higher (Most of the distributions have these required packages. They may be called - gnuplot-py, phython-gnuplot or phython3-gnuplot, gnuplot-nox, ... ) + gnuplot-py, python-gnuplot or python3-gnuplot, gnuplot-nox, ... ) HWP (Hardware P-States are disabled) Kernel config for Linux trace is enabled@@ -23,7 +23,7 @@ Prerequisites: see print_help(): for Usage and Output details """ -from __future__ import print_function + from datetime import datetime import subprocess import os@@ -562,7 +562,7 @@ if __name__ == "__main__": # Temporary (or perhaps not) cur_version = sys.version_info - print('python version (should be >= 2.7):') + print('python version (should be >= 3.6):') print(cur_version) # Left as "cleanup" for potential future re-run ability. --2.25.1
Quoted 7 lines · Doug Smythies
From: Doug Smythies <[email protected]>
Change the minimum python version from 2.7 to 3.6. Remove a 2.X backwards compatibility line.
Signed-off-by Doug Smythies <[email protected]>
Quoted 9 lines
---
v2 -> v3: Try to fix mess that was v2.
v1 -> v2: Fix careless typos.---
.../x86/intel_pstate_tracer/intel_pstate_tracer.py| 12 ++++++------1 file changed, 6 insertions(+), 6 deletions(-)
Quoted 47 lines
tools/power/x86/intel_pstate_tracer/intel_pstate_tracer.py +6
-7@@ -1,4 +1,4 @@ -#!/usr/bin/env python +#!/usr/bin/env python3 # SPDX-License-Identifier: GPL-2.0-only # -*- coding: utf-8 -*- #@@ -11,11 +11,11 @@ then this utility enables and collects trace data for a user specified interval and generates performance plots. Prerequisites: - Python version 2.7.x or higher + Python version 3.6.x or higher gnuplot 5.0 or higher - gnuplot-py 1.8 or higher + python3-gnuplot 1.8 or higher (Most of the distributions have these required packages. They may be called - gnuplot-py, phython-gnuplot or phython3-gnuplot, gnuplot-nox, ... ) + gnuplot-py, python-gnuplot or python3-gnuplot, gnuplot-nox, ... ) HWP (Hardware P-States are disabled) Kernel config for Linux trace is enabled@@ -23,7 +23,7 @@ Prerequisites: see print_help(): for Usage and Output details """ -from __future__ import print_function + from datetime import datetime import subprocess import os@@ -562,7 +562,7 @@ if __name__ == "__main__": # Temporary (or perhaps not) cur_version = sys.version_info - print('python version (should be >= 2.7):') + print('python version (should be >= 3.6):') print(cur_version) # Left as "cleanup" for potential future re-run ability. --2.25.1