Skip to contentSkip to conversation

mmc: core: Support packed command feature of eMMC4.5

PATCH Superseded Seungwon Jeon 4 participants 4 messages Jan 20, 2012 – Jan 23, 2012 MMC, SD and SDIO

v3 of 9 Superseded Latest is v9 →

lore
Share & tools
lore
#0 lore raw

v3 cover mmc: core: Support packed command feature of eMMC4.5

This patch-set adds support of packed command feature for eMMC4.5 devices.

Changes in v3:
- Add a variable member in mmc_host for minimum number of packed entries. This value can be overrided by host.
- Fix a handling of error sequence.

Changes in v2:
- Fix the packed read sequence and error handling.
- Apply checking the exception status for all cases with
the comments from Maya Erez and Sahitya Tummala.
- Fix preparing the packed list with the comment from Maya Erez and Venkatraman.

Seungwon Jeon (2):
mmc: core: Add packed command feature of eMMC4.5
mmc: core: Support packed command for eMMC4.5 device

 drivers/mmc/card/block.c   |  469 +++++++++++++++++++++++++++++++++++++++++---
 drivers/mmc/card/queue.c   |   48 +++++-
 drivers/mmc/card/queue.h   |   13 ++
 drivers/mmc/core/host.c    |    2 +
 drivers/mmc/core/mmc.c     |   24 +++
 drivers/mmc/core/mmc_ops.c |    1 +
 include/linux/mmc/card.h   |    3 +
 include/linux/mmc/core.h   |    3 +
 include/linux/mmc/host.h   |    4 +
 include/linux/mmc/mmc.h    |   15 ++
 10 files changed, 555 insertions(+), 27 deletions(-)

Best regards,
Seungwon Jeon.
--
1.7.2.3

Acked-by on the v3 series
#1 lore raw

Hi,

FYI: we get performance gain using packed command at write. however in case of small size read, there are some performance drop since protocol overhead.
In normal case, read command uses read operation only, but in case of packed read. It sends the command to eMMC and read it. Anyway it's good feature for eMMC v4.5.

Quoted 44 lines · Seungwon Jeon

This patch-set adds support of packed command feature for eMMC4.5 devices.

Changes in v3:
- Add a variable member in mmc_host for minimum number of packed entries. This value can be overrided by host.
- Fix a handling of error sequence.

Changes in v2:
- Fix the packed read sequence and error handling.
- Apply checking the exception status for all cases with the comments from Maya Erez and Sahitya Tummala.
- Fix preparing the packed list with the comment from Maya Erez and
Venkatraman.

Seungwon Jeon (2):
mmc: core: Add packed command feature of eMMC4.5
mmc: core: Support packed command for eMMC4.5 device

 drivers/mmc/card/block.c   |  469
+++++++++++++++++++++++++++++++++++++++++---
 drivers/mmc/card/queue.c   |   48 +++++-
 drivers/mmc/card/queue.h   |   13 ++
 drivers/mmc/core/host.c    |    2 +
 drivers/mmc/core/mmc.c     |   24 +++
 drivers/mmc/core/mmc_ops.c |    1 +
 include/linux/mmc/card.h   |    3 +
 include/linux/mmc/core.h   |    3 +
 include/linux/mmc/host.h   |    4 +
 include/linux/mmc/mmc.h    |   15 ++
 10 files changed, 555 insertions(+), 27 deletions(-)

Best regards,
Seungwon Jeon.
--
1.7.2.3

--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

#2 lore raw

Hi. Seungwon,

Would you show improved performance measurement result(read/write,seq,ran) when using packed cmd ?

Thanks.

2012/1/20 Kyungmin Park <[email protected]>:

Quoted 61 lines

Hi,

FYI: we get performance gain using packed command at write. however in case of small size read, there are some performance drop since protocol overhead.
In normal case, read command uses read operation only, but in case of packed read. It sends the command to eMMC and read it. Anyway it's good feature for eMMC v4.5.

Quoted 39 lines · Seungwon Jeon

This patch-set adds support of packed command feature for eMMC4.5 devices.

Changes in v3:
      - Add a variable member in mmc_host for minimum number of packed entries. This value can be overrided by host.
      - Fix a handling of error sequence.

Changes in v2:
      - Fix the packed read sequence and error handling.
      - Apply checking the exception status for all cases with the comments from Maya Erez and Sahitya Tummala.
      - Fix preparing the packed list with the comment from Maya Erez and Venkatraman.

Seungwon Jeon (2):
      mmc: core: Add packed command feature of eMMC4.5
      mmc: core: Support packed command for eMMC4.5 device

 drivers/mmc/card/block.c   |  469
+++++++++++++++++++++++++++++++++++++++++---
 drivers/mmc/card/queue.c   |   48 +++++-
 drivers/mmc/card/queue.h   |   13 ++
 drivers/mmc/core/host.c    |    2 +
 drivers/mmc/core/mmc.c     |   24 +++
 drivers/mmc/core/mmc_ops.c |    1 +

 include/linux/mmc/card.h   |    3 +
 include/linux/mmc/core.h   |    3 +
 include/linux/mmc/host.h   |    4 +
 include/linux/mmc/mmc.h    |   15 ++
 10 files changed, 555 insertions(+), 27 deletions(-)

Best regards,
Seungwon Jeon.
--
1.7.2.3

Quoted 5 lines

--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

#3 lore raw
In reply to Kyungmin Park
Quoted 9 lines · Kyungmin Park

Hi,

FYI: we get performance gain using packed command at write. however in case of small size read, there are some performance drop since protocol overhead.
In normal case, read command uses read operation only, but in case of packed read. It sends the command to eMMC and read it. Anyway it's good feature for eMMC v4.5.

I believe the improvement will vary depending on how many commands are packed, which will depend on use case (e.g. CPU load, rate of application read/write), file system state (e.g. fragmentation, amount of free space) etc. It will be very interesting if you can publish the details of what you have tested and your observation of different parameters related to packed command.

Quoted 51 lines
Quoted 39 lines · Seungwon Jeon

This patch-set adds support of packed command feature for eMMC4.5 devices.

Changes in v3:
      - Add a variable member in mmc_host for minimum number of packed entries. This value can be overrided by host.
      - Fix a handling of error sequence.

Changes in v2:
      - Fix the packed read sequence and error handling.
      - Apply checking the exception status for all cases with the comments from Maya Erez and Sahitya Tummala.
      - Fix preparing the packed list with the comment from Maya Erez and Venkatraman.

Seungwon Jeon (2):
      mmc: core: Add packed command feature of eMMC4.5
      mmc: core: Support packed command for eMMC4.5 device

 drivers/mmc/card/block.c   |  469
+++++++++++++++++++++++++++++++++++++++++---
 drivers/mmc/card/queue.c   |   48 +++++-
 drivers/mmc/card/queue.h   |   13 ++
 drivers/mmc/core/host.c    |    2 +
 drivers/mmc/core/mmc.c     |   24 +++
 drivers/mmc/core/mmc_ops.c |    1 +

 include/linux/mmc/card.h   |    3 +
 include/linux/mmc/core.h   |    3 +
 include/linux/mmc/host.h   |    4 +
 include/linux/mmc/mmc.h    |   15 ++
 10 files changed, 555 insertions(+), 27 deletions(-)

Best regards,
Seungwon Jeon.
--
1.7.2.3

Quoted 5 lines

--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html