Skip to contentSkip to conversation

crypto: mv_cesa: remove unnecessary platform_set_drvdata()

PATCH Applied Jingoo Han 2 participants 2 messages May 6, 2013 Crypto API

lore
Share & tools
lore

Jingoo Han

author
#0 lore raw

PATCH 1/2 crypto: mv_cesa: remove unnecessary platform_set_drvdata()

The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.

---
 drivers/crypto/mv_cesa.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/crypto/mv_cesa.c +0 -1
index ce6290e..3374a3e 100644
@@ -1146,7 +1146,6 @@ err_unmap_reg:
 err:
 	kfree(cp);
 	cpg = NULL;
-	platform_set_drvdata(pdev, NULL);
 	return ret;
 }
 
Signature · 1 line
1.7.2.5
Acked-by on v1 1/2
#1 lore raw
Quoted 15 lines · Jingoo Han

The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.

---
 drivers/crypto/mv_cesa.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/crypto/mv_cesa.c +0 -0
index ce6290e..3374a3e 100644

drivers/crypto/mv_cesa.c err_unmap_reg: · line 1151

Quoted 7 lines
drivers/crypto/mv_cesa.c +0 -1
@@ -1146,7 +1146,6 @@ err_unmap_reg:
 err:
 	kfree(cp);
 	cpg = NULL;
-	platform_set_drvdata(pdev, NULL);
 	return ret;
 }