rtc: rtc-max8998: remove unnecessary platform_set_drvdata()
PATCH 24/42 rtc: rtc-max8998: remove unnecessary platform_set_drvdata()
The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.
Signed-off-by Jingoo Han <[email protected]>
--- drivers/rtc/rtc-max8998.c | 6 +----- 1 files changed, 1 insertions(+), 5 deletions(-)
drivers/rtc/rtc-max8998.c +1 -5
@@ -274,7 +274,7 @@ static int max8998_rtc_probe(struct platform_device *pdev)if (IS_ERR (info->rtc_dev)) { ret =PTR_ERR (info->rtc_dev);dev_err (&pdev->dev,"Failed to register RTC device: %d\n" , ret); - goto out_rtc; +return ret; } ret = devm_request_threaded_irq(&pdev->dev, info->irq, NULL,
@@ -292,10 +292,6 @@ static int max8998_rtc_probe(struct platform_device *pdev) }return 0 ; - -out_rtc: -platform_set_drvdata (pdev,NULL ); -return ret; }static int max8998_rtc_remove (struct platform_device *pdev)
Signature · 1 line
1.7.2.5