mmc: dw_mmc: add missing MFD_SYSCON dependency for SOCFPGA

PATCH In review Jingoo Han 5 participants 7 messages Aug 1, 2013 – Aug 25, 2013 MMC, SD and SDIO

lore

Share & tools

lore

Jingoo Han

author

2013-08-01 00:28 UTC #0 lore raw

PATCH 1/1 mmc: dw_mmc: add missing MFD_SYSCON dependency for SOCFPGA

Added missing MFD_SYSCON dependency for SOCFPGA in order to fix the following link error.

drivers/mmc/host/dw_mmc-socfpga.c:49: undefined reference to `syscon_regmap_lookup_by_compatible'

Signed-off-by Jingoo Han <[email protected]>

---
 drivers/mmc/host/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/mmc/host/Kconfig +1 -1

index 8a4c066..84102bc 100644
@@ -569,7 +569,7 @@ config MMC_DW_EXYNOS
 
 config MMC_DW_SOCFPGA
 	tristate "SOCFPGA specific extensions for Synopsys DW Memory Card Interface"
-	depends on MMC_DW
+	depends on MMC_DW && MFD_SYSCON
 	select MMC_DW_PLTFM
 	help
 	  This selects support for Altera SoCFPGA specific extensions to the

Signature · 1 line

1.7.10.4

Jaehoon Chung

2013-08-01 14:52 UTC #1 lore raw

When I used socfpga_defconfig, MFD_SYSCON is enabled. Which config do you use?

Best Regards,
Jaehoon Chung

Quoted 24 lines · Jingoo Han

Added missing MFD_SYSCON dependency for SOCFPGA in order to fix the following link error.
drivers/mmc/host/dw_mmc-socfpga.c:49: undefined reference to `syscon_regmap_lookup_by_compatible'
Signed-off-by Jingoo Han <[email protected]>
---
 drivers/mmc/host/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/host/Kconfig +1 -1
index 8a4c066..84102bc 100644
@@ -569,7 +569,7 @@ config MMC_DW_EXYNOS
 
 config MMC_DW_SOCFPGA
 	tristate "SOCFPGA specific extensions for Synopsys DW Memory Card Interface"
-	depends on MMC_DW
+	depends on MMC_DW && MFD_SYSCON
 	select MMC_DW_PLTFM
 	help
 	  This selects support for Altera SoCFPGA specific extensions to the

Dinh Nguyen

2013-08-01 14:58 UTC #2 lore raw

Quoted 3 lines · Jaehoon Chung

When I used socfpga_defconfig, MFD_SYSCON is enabled. Which config do you use?

Yes, select MFD_SYSCON is in mach-socfpga/Kconfig. This should have fixed this error.

commit 1780db9e2104 ARM: socfpga: Add syscon to be part of socfpga

Dinh

Quoted 30 lines

Best Regards,
Jaehoon Chung
Quoted 24 lines · Jingoo Han
Added missing MFD_SYSCON dependency for SOCFPGA in order to fix the following link error.
drivers/mmc/host/dw_mmc-socfpga.c:49: undefined reference to `syscon_regmap_lookup_by_compatible'
Signed-off-by Jingoo Han <[email protected]>
---
 drivers/mmc/host/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/host/Kconfig +1 -1
index 8a4c066..84102bc 100644
@@ -569,7 +569,7 @@ config MMC_DW_EXYNOS
 
 config MMC_DW_SOCFPGA
 	tristate "SOCFPGA specific extensions for Synopsys DW Memory Card Interface"
-	depends on MMC_DW
+	depends on MMC_DW && MFD_SYSCON
 	select MMC_DW_PLTFM
 	help
 	  This selects support for Altera SoCFPGA specific extensions to the

Jingoo Han

author

2013-08-01 23:22 UTC #3 lore raw

Quoted 9 lines · Dinh Nguyen

Quoted 3 lines · Jaehoon Chung
When I used socfpga_defconfig, MFD_SYSCON is enabled. Which config do you use?
Yes, select MFD_SYSCON is in mach-socfpga/Kconfig. This should have fixed this error.
commit 1780db9e2104 ARM: socfpga: Add syscon to be part of socfpga

+CC Fengguang Wu, Dan Carpenter, Arnd Bergmann

I used exynos_defconfig, and enabled socfpga mmc driver through menuconfig. Also, 'drivers/mmc/host/dw_mmc-socfpga.c' is used by ARCH_SOCFPGA. However, even though other configs are used, it should not make build error or link error.

Please look at other drivers using MFD_SYSCON.
i.mx config also selects MFD_SYSCON; however, it added MFD_SYSCON dependency in order to prevent link error.

(./arch/arm/mach-imx/Kconfig)
786: config SOC_IMX6Q
804: select MFD_SYSCON

813: config SOC_IMX6SL
825: select MFD_SYSCON

(./drivers/regulator/Kconfig)
90: config REGULATOR_ANATOP
91: tristate "Freescale i.MX on-chip ANATOP LDO regulators"
92: depends on MFD_SYSCON

Best regards,
Jingoo Han

Quoted 33 lines

Dinh
Quoted 30 lines
Best Regards,
Jaehoon Chung
Quoted 24 lines · Jingoo Han
Added missing MFD_SYSCON dependency for SOCFPGA in order to fix the following link error.
drivers/mmc/host/dw_mmc-socfpga.c:49: undefined reference to `syscon_regmap_lookup_by_compatible'
Signed-off-by Jingoo Han <[email protected]>
---
 drivers/mmc/host/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/host/Kconfig +1 -1
index 8a4c066..84102bc 100644
@@ -569,7 +569,7 @@ config MMC_DW_EXYNOS
 
 config MMC_DW_SOCFPGA
 	tristate "SOCFPGA specific extensions for Synopsys DW Memory Card Interface"
-	depends on MMC_DW
+	depends on MMC_DW && MFD_SYSCON
 	select MMC_DW_PLTFM
 	help
 	  This selects support for Altera SoCFPGA specific extensions to the

Jaehoon Chung

Acked-by

2013-08-02 03:48 UTC #4 lore raw

Hi Jingoo,

I checked exynos_defconfig as your comment.
I also found the compiler error. thanks for your effort.

Acked-by Jaehoon Chung <[email protected]>

Best Regards,
Jaehoon Chung

Quoted 78 lines · Jingoo Han

Quoted 9 lines · Dinh Nguyen
Quoted 3 lines · Jaehoon Chung
When I used socfpga_defconfig, MFD_SYSCON is enabled. Which config do you use?
Yes, select MFD_SYSCON is in mach-socfpga/Kconfig. This should have fixed this error.
commit 1780db9e2104 ARM: socfpga: Add syscon to be part of socfpga
+CC Fengguang Wu, Dan Carpenter, Arnd Bergmann
I used exynos_defconfig, and enabled socfpga mmc driver through menuconfig. Also, 'drivers/mmc/host/dw_mmc-socfpga.c' is used by ARCH_SOCFPGA. However, even though other configs are used, it should not make build error or link error.
Please look at other drivers using MFD_SYSCON.
i.mx config also selects MFD_SYSCON; however, it added MFD_SYSCON dependency in order to prevent link error.
(./arch/arm/mach-imx/Kconfig)
786: config SOC_IMX6Q
804: select MFD_SYSCON
813: config SOC_IMX6SL
825: select MFD_SYSCON
(./drivers/regulator/Kconfig)
90: config REGULATOR_ANATOP
91: tristate "Freescale i.MX on-chip ANATOP LDO regulators"
92: depends on MFD_SYSCON
Best regards,
Jingoo Han
Quoted 33 lines
Dinh
Quoted 30 lines
Best Regards,
Jaehoon Chung
Quoted 24 lines · Jingoo Han
Added missing MFD_SYSCON dependency for SOCFPGA in order to fix the following link error.
drivers/mmc/host/dw_mmc-socfpga.c:49: undefined reference to `syscon_regmap_lookup_by_compatible'
Signed-off-by Jingoo Han <[email protected]>
---
 drivers/mmc/host/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/host/Kconfig +1 -1
index 8a4c066..84102bc 100644
@@ -569,7 +569,7 @@ config MMC_DW_EXYNOS
 
 config MMC_DW_SOCFPGA
 	tristate "SOCFPGA specific extensions for Synopsys DW Memory Card Interface"
-	depends on MMC_DW
+	depends on MMC_DW && MFD_SYSCON
 	select MMC_DW_PLTFM
 	help
 	  This selects support for Altera SoCFPGA specific extensions to the
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Seungwon Jeon

Acked-by on v1 1/1

2013-08-09 13:31 UTC #5 lore raw

In reply to Jingoo Han

Quoted 6 lines · Jingoo Han

Added missing MFD_SYSCON dependency for SOCFPGA in order to fix the following link error.
drivers/mmc/host/dw_mmc-socfpga.c:49: undefined reference to `syscon_regmap_lookup_by_compatible'
Signed-off-by Jingoo Han <[email protected]>

Acked-by Seungwon Jeon <[email protected]>

Chris Ball

2013-08-25 03:33 UTC #6 lore raw

Hi,

Quoted 10 lines · Seungwon Jeon

Quoted 7 lines · Jingoo Han
Added missing MFD_SYSCON dependency for SOCFPGA in order to fix the following link error.
drivers/mmc/host/dw_mmc-socfpga.c:49: undefined reference to syscon_regmap_lookup_by_compatible'
Signed-off-by Jingoo Han <[email protected]>
Acked-by Seungwon Jeon <[email protected]>

Thanks, pushed to mmc-next for 3.12.

- Chris.

Signature · 1 line

Chris Ball   <[email protected]>   <http://printf.net/>