Skip to contentSkip to conversation

mfd: mc13xxx: remove unnecessary spi_set_drvdata()

PATCH Applied Jingoo Han 2 participants 2 messages Nov 25, 2013 Multifunction devices (MFD)

lore
Share & tools
lore

Jingoo Han

author
#0 lore raw

PATCH 1/1 mfd: mc13xxx: remove unnecessary spi_set_drvdata()

The driver core clears the driver data to NULL after device_release or on probe failure. Thus, it is not needed to manually clear the device driver data to NULL.

---
 drivers/mfd/mc13xxx-spi.c |    1 -
 1 file changed, 1 deletion(-)
drivers/mfd/mc13xxx-spi.c +0 -1
index 5f14ef6..cbcc86d 100644
@@ -149,7 +149,6 @@ static int mc13xxx_spi_probe(struct spi_device *spi)
 		ret = PTR_ERR(mc13xxx->regmap);
 		dev_err(mc13xxx->dev, "Failed to initialize register map: %d\n",
 				ret);
-		spi_set_drvdata(spi, NULL);
 		return ret;
 	}
 
Signature · 1 line
1.7.10.4
Applied
#1 lore raw
Quoted 8 lines · Jingoo Han

The driver core clears the driver data to NULL after device_release or on probe failure. Thus, it is not needed to manually clear the device driver data to NULL.

---
 drivers/mfd/mc13xxx-spi.c |    1 -
 1 file changed, 1 deletion(-)

Applied, thanks.

Signature · 4 lines
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog