Skip to contentSkip to conversation

atm: he: remove unnecessary pci_set_drvdata()

PATCH New Jingoo Han 1 participant 2 messages Nov 25, 2013

Subsystems (3)
lore
Share & tools
lore

Jingoo Han

author
#0 lore raw

PATCH 1/2 atm: he: remove unnecessary pci_set_drvdata()

The driver core clears the driver data to NULL after device_release or on probe failure. Thus, it is not needed to manually clear the device driver data to NULL.

---
 drivers/atm/he.c |    1 -
 1 file changed, 1 deletion(-)
drivers/atm/he.c +0 -1
index 8557adc..aa6be26 100644
@@ -419,7 +419,6 @@ static void he_remove_one(struct pci_dev *pci_dev)
 	atm_dev_deregister(atm_dev);
 	kfree(he_dev);
 
-	pci_set_drvdata(pci_dev, NULL);
 	pci_disable_device(pci_dev);
 }
 
Signature · 1 line
1.7.10.4
author
#1 lore raw

PATCH 2/2 atm: solos-pci: remove unnecessary pci_set_drvdata()

The driver core clears the driver data to NULL after device_release or on probe failure. Thus, it is not needed to manually clear the device driver data to NULL.

---
 drivers/atm/solos-pci.c |    2 --
 1 file changed, 2 deletions(-)
drivers/atm/solos-pci.c +0 -2
index 32784d1..e3fb496 100644
@@ -1335,7 +1335,6 @@ static int fpga_probe(struct pci_dev *dev, const struct pci_device_id *id)
 	
  out_unmap_both:
 	kfree(card->dma_bounce);
-	pci_set_drvdata(dev, NULL);
 	pci_iounmap(dev, card->buffers);
  out_unmap_config:
 	pci_iounmap(dev, card->config_regs);
@@ -1457,7 +1456,6 @@ static void fpga_remove(struct pci_dev *dev)
 	pci_release_regions(dev);
 	pci_disable_device(dev);
 
-	pci_set_drvdata(dev, NULL);
 	kfree(card);
 }
 
Signature · 1 line
1.7.10.4