Skip to contentSkip to conversation

KCSAN Support on ARM64 Kernel

DISCUSSION Dmitry Vyukov 4 participants 9 messages Oct 14, 2019 – Jun 15, 2020 2 messages not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 5 lines · On Mon, Oct 14, 2019 at 7:11 AM <[email protected]> wrote:

Hi Dmitry,

I am from Qualcomm Linux Security Team, just going through KCSAN and found that there was a thread for arm64 support (https://lkml.org/lkml/2019/9/20/804).

Quoted 7 lines

Can you please tell me if KCSAN is supported on ARM64 now? Can I just rebase the KCSAN branch on top of our let’s say android mainline kernel, enable the config and run syzkaller on that for finding race conditions?

It would be very helpful if you reply, we want to setup this for finding issues on our proprietary modules that are not part of kernel mainline.

Regards,

Sachin Grover

+more people re KCSAN on ARM64

#2 lore raw
Quoted 9 lines · Dmitry Vyukov
Quoted 7 lines · On Mon, Oct 14, 2019 at 7:11 AM <[email protected]> wrote:

Hi Dmitry,

I am from Qualcomm Linux Security Team, just going through KCSAN and found that there was a thread for arm64 support (https://lkml.org/lkml/2019/9/20/804).

Can you please tell me if KCSAN is supported on ARM64 now? Can I just rebase the KCSAN branch on top of our let’s say android mainline kernel, enable the config and run syzkaller on that for finding race conditions?

Quoted 7 lines
Quoted 5 lines

It would be very helpful if you reply, we want to setup this for finding issues on our proprietary modules that are not part of kernel mainline.

Regards,

Sachin Grover

+more people re KCSAN on ARM64

KCSAN does not yet have ARM64 support. Once it's upstream, I would expect that Mark's patches (from repo linked in LKML thread) will just cleanly apply to enable ARM64 support.

Thanks,
-- Marco

#3 lore raw

Hi Marco,

When can we expect upstream of KCSAN on kernel mainline. Any timeline?

Regards,
Sachin Grover

-----Original Message-----
From: Marco Elver <[email protected]>
Sent: Monday, 14 October, 2019 2:40 PM
To: Dmitry Vyukov <[email protected]>
Cc: [email protected]; kasan-dev <[email protected]>; LKML <[email protected]>; Paul E. McKenney <[email protected]>; Will Deacon <[email protected]>; Andrea Parri <[email protected]>; Alan Stern <[email protected]>; Mark Rutland <[email protected]>
Subject: Re: KCSAN Support on ARM64 Kernel

Quoted 9 lines · Dmitry Vyukov
Quoted 7 lines · On Mon, Oct 14, 2019 at 7:11 AM <[email protected]> wrote:

Hi Dmitry,

I am from Qualcomm Linux Security Team, just going through KCSAN and found that there was a thread for arm64 support (https://lkml.org/lkml/2019/9/20/804).

Can you please tell me if KCSAN is supported on ARM64 now? Can I just rebase the KCSAN branch on top of our let’s say android mainline kernel, enable the config and run syzkaller on that for finding race conditions?

Quoted 7 lines
Quoted 5 lines

It would be very helpful if you reply, we want to setup this for finding issues on our proprietary modules that are not part of kernel mainline.

Regards,

Sachin Grover

+more people re KCSAN on ARM64

KCSAN does not yet have ARM64 support. Once it's upstream, I would expect that Mark's patches (from repo linked in LKML thread) will just cleanly apply to enable ARM64 support.

Thanks,
-- Marco

#4 lore raw

Hi Sachin,

My plan was to send patches upstream within the month.

Thanks,
-- Marco

Quoted 38 lines · On Mon, 14 Oct 2019 at 11:30, <[email protected]> wrote:

Hi Marco,

When can we expect upstream of KCSAN on kernel mainline. Any timeline?

Regards,
Sachin Grover

-----Original Message-----
From: Marco Elver <[email protected]>
Sent: Monday, 14 October, 2019 2:40 PM
To: Dmitry Vyukov <[email protected]>
Cc: [email protected]; kasan-dev <[email protected]>; LKML <[email protected]>; Paul E. McKenney <[email protected]>; Will Deacon <[email protected]>; Andrea Parri <[email protected]>; Alan Stern <[email protected]>; Mark Rutland <[email protected]>
Subject: Re: KCSAN Support on ARM64 Kernel

Quoted 9 lines · Dmitry Vyukov
Quoted 7 lines · On Mon, Oct 14, 2019 at 7:11 AM <[email protected]> wrote:

Hi Dmitry,

I am from Qualcomm Linux Security Team, just going through KCSAN and found that there was a thread for arm64 support (https://lkml.org/lkml/2019/9/20/804).

Can you please tell me if KCSAN is supported on ARM64 now? Can I just rebase the KCSAN branch on top of our let’s say android mainline kernel, enable the config and run syzkaller on that for finding race conditions?

Quoted 7 lines
Quoted 5 lines

It would be very helpful if you reply, we want to setup this for finding issues on our proprietary modules that are not part of kernel mainline.

Regards,

Sachin Grover

+more people re KCSAN on ARM64

KCSAN does not yet have ARM64 support. Once it's upstream, I would expect that Mark's patches (from repo linked in LKML thread) will just cleanly apply to enable ARM64 support.

Thanks,
-- Marco

#5 lore raw
Quoted 1 line · Marco Elver

My plan was to send patches upstream within the month.

[...]

Quoted 1 line · On Mon, 14 Oct 2019 at 11:30, <[email protected]> wrote:

[...]

Quoted 1 line
Quoted 1 line

When can we expect upstream of KCSAN on kernel mainline. Any timeline?

[...]

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

Can you please tell me if KCSAN is supported on ARM64 now? Can I just rebase the KCSAN branch on top of our let’s say android mainline kernel, enable the config and run syzkaller on that for finding race conditions?

[...]

Quoted 1 line
Quoted 1 line

KCSAN does not yet have ARM64 support. Once it's upstream, I would expect that Mark's patches (from repo linked in LKML thread) will just cleanly apply to enable ARM64 support.

Just FYI, KCSAN is in mainline now. I believe porting it to other architectures has also become much simpler due to its reworked ONCE/atomic support relying on proper compiler instrumentation instead of other tricks.

Thanks,
-- Marco

#6 lore raw
In reply to Marco Elver
Quoted 21 lines · Marco Elver
Quoted 20 lines · Dmitry Vyukov
Quoted 18 lines · On Mon, Oct 14, 2019 at 7:11 AM <[email protected]> wrote:

Hi Dmitry,

I am from Qualcomm Linux Security Team, just going through KCSAN and found that there was a thread for arm64 support
(https://lkml.org/lkml/2019/9/20/804).

Can you please tell me if KCSAN is supported on ARM64 now? Can I just rebase the KCSAN branch on top of our let’s say android mainline kernel, enable the config and run syzkaller on that for finding race conditions?

It would be very helpful if you reply, we want to setup this for finding issues on our proprietary modules that are not part of kernel mainline.

Regards,

Quoted 7 lines
Quoted 3 lines
Quoted 1 line

Sachin Grover

+more people re KCSAN on ARM64

KCSAN does not yet have ARM64 support. Once it's upstream, I would expect that Mark's patches (from repo linked in LKML thread) will just cleanly apply to enable ARM64 support.

Once the core kcsan bits are ready, I'll rebase the arm64 patch atop. I'm expecting some things to change as part of review, so it'd be great to see that posted ASAP.

For arm64 I'm not expecting major changes (other than those necessary to handle the arm64 atomic rework that went in to v5.4-rc1)

FWIW, I was able to run Syzkaller atop of my arm64/kcsan branch, but it's very noisy as it has none of the core fixes.

Thanks,
Mark.

#7 lore raw

Hi All,

Is there any update in Arm64 support of KCSAN.

Regards,
Sachin Grover

-----Original Message-----
From: Mark Rutland <[email protected]>
Sent: Monday, 14 October, 2019 3:50 PM
To: Marco Elver <[email protected]>
Cc: Dmitry Vyukov <[email protected]>; [email protected]; kasan-dev <[email protected]>; LKML <[email protected]>; Paul E. McKenney <[email protected]>; Will Deacon <[email protected]>; Andrea Parri <[email protected]>; Alan Stern <[email protected]>
Subject: Re: KCSAN Support on ARM64 Kernel

Quoted 21 lines · Marco Elver
Quoted 20 lines · Dmitry Vyukov
Quoted 18 lines · On Mon, Oct 14, 2019 at 7:11 AM <[email protected]> wrote:

Hi Dmitry,

I am from Qualcomm Linux Security Team, just going through KCSAN and found that there was a thread for arm64 support
(https://lkml.org/lkml/2019/9/20/804).

Can you please tell me if KCSAN is supported on ARM64 now? Can I just rebase the KCSAN branch on top of our let’s say android mainline kernel, enable the config and run syzkaller on that for finding race conditions?

It would be very helpful if you reply, we want to setup this for finding issues on our proprietary modules that are not part of kernel mainline.

Regards,

Quoted 7 lines
Quoted 3 lines
Quoted 1 line

Sachin Grover

+more people re KCSAN on ARM64

KCSAN does not yet have ARM64 support. Once it's upstream, I would expect that Mark's patches (from repo linked in LKML thread) will just cleanly apply to enable ARM64 support.

Once the core kcsan bits are ready, I'll rebase the arm64 patch atop.
I'm expecting some things to change as part of review, so it'd be great to see that posted ASAP.

For arm64 I'm not expecting major changes (other than those necessary to handle the arm64 atomic rework that went in to v5.4-rc1)

FWIW, I was able to run Syzkaller atop of my arm64/kcsan branch, but it's very noisy as it has none of the core fixes.

Thanks,
Mark.

#8 lore raw

We're in the process of upstreaming KCSAN, which will simplify a lot of things including Arm64 support. So far KCSAN is not yet in mainline, but I assume when that happens (if things go well, very soon) it should be trivial to add Arm64 support based on Mark's prototype.

Thanks,
-- Marco

Quoted 55 lines · On Mon, 2 Dec 2019 at 06:07, <[email protected]> wrote:

Hi All,

Is there any update in Arm64 support of KCSAN.

Regards,
Sachin Grover

-----Original Message-----
From: Mark Rutland <[email protected]>
Sent: Monday, 14 October, 2019 3:50 PM
To: Marco Elver <[email protected]>
Cc: Dmitry Vyukov <[email protected]>; [email protected]; kasan-dev <[email protected]>; LKML <[email protected]>; Paul E. McKenney <[email protected]>; Will Deacon <[email protected]>; Andrea Parri <[email protected]>; Alan Stern <[email protected]>
Subject: Re: KCSAN Support on ARM64 Kernel

Quoted 21 lines · Marco Elver
Quoted 20 lines · Dmitry Vyukov
Quoted 18 lines · On Mon, Oct 14, 2019 at 7:11 AM <[email protected]> wrote:

Hi Dmitry,

I am from Qualcomm Linux Security Team, just going through KCSAN and found that there was a thread for arm64 support
(https://lkml.org/lkml/2019/9/20/804).

Can you please tell me if KCSAN is supported on ARM64 now? Can I just rebase the KCSAN branch on top of our let’s say android mainline kernel, enable the config and run syzkaller on that for finding race conditions?

It would be very helpful if you reply, we want to setup this for finding issues on our proprietary modules that are not part of kernel mainline.

Regards,

Quoted 7 lines
Quoted 3 lines
Quoted 1 line

Sachin Grover

+more people re KCSAN on ARM64

KCSAN does not yet have ARM64 support. Once it's upstream, I would expect that Mark's patches (from repo linked in LKML thread) will just cleanly apply to enable ARM64 support.

Once the core kcsan bits are ready, I'll rebase the arm64 patch atop.
I'm expecting some things to change as part of review, so it'd be great to see that posted ASAP.

For arm64 I'm not expecting major changes (other than those necessary to handle the arm64 atomic rework that went in to v5.4-rc1)

FWIW, I was able to run Syzkaller atop of my arm64/kcsan branch, but it's very noisy as it has none of the core fixes.

Thanks,
Mark.

A message that is not in the archive (sent off-list or not yet received): 0101016efaeb3a3b-81a8c0fa-c656-4f95-9864-c7f4573024fd-000000@us-west-2.amazonses.com

#10 lore raw

Hi Mukesh,

In future *please* reply in plaintext rather than HTML.

Quoted 11 lines · Mukesh Ojha
Quoted 6 lines · Mark Rutland

Once the core kcsan bits are ready, I'll rebase the arm64 patch atop. I'm expecting some things to change as part of review, so it'd be great to see that posted ASAP.

For arm64 I'm not expecting major changes (other than those necessary to handle the arm64 atomic rework that went in to v5.4-rc1)

Hi Mark,

Are the below patches enough for kcsan to be working on arm64 ?

That depends on what branch you're using as a base. My arm64/kcsan branch worked for me as-is, but as I mentioned that was /very/ noisy. Both the kcsan code and the arm64 code have moved on since then, and I have no idea how well that would backport.

I had a quick go at porting my arm64 patch atop the kcsan branch in Paul's tree, and that doesn't get as far as producing earlycon output, so more work will be necessary to investigate and debug that.

I hope to look at that, but I don't think I'll have the chance to do so before the end of next week.

Quoted 2 lines

I am not sure about the one you are mentioning about "atomic rework patches which went in 5.4 rc1" .

There were a number of patches from Andrew Murray reworking the arm64 atomic implementation. See:

$ git log v5.3..v5.4-rc1 --author='Andrew Murray' -- arch/arm64

With those patches applied, my change to arch/arm64/lib/Makefile is unnecessary and can be dropped.

Thanks,
Mark.

Quoted 20 lines

2019-10-03 arm64, kcsan: enable KCSAN for arm64 <https://git.kernel.org/pub/scm/linux/kernel/git/mark/linux.git/commit/?h=arm64/kcsan&id=ae1d089527027ce710e464105a73eb0db27d7875>arm64/kcsan <https://git.kernel.org/pub/scm/linux/kernel/git/mark/linux.git/log/?h=arm64/kcsan>

	Mark Rutland 	5 	-1/+5

2019-09-24 locking/atomics, kcsan: Add KCSAN instrumentation <https://git.kernel.org/pub/scm/linux/kernel/git/mark/linux.git/commit/?h=arm64/kcsan&id=8b3b76ec443b9af7e55994a163bb6f4aee016f09>

	Marco Elver 	2 	-2/+199
2019-09-24 	asm-generic, kcsan: Add KCSAN instrumentation for bitops <https://git.kernel.org/pub/scm/linux/kernel/git/mark/linux.git/commit/?h=arm64/kcsan&id=50c23ad00c040927e71c8943d4eb7d52e9f77762>
	Marco Elver 	1 	-0/+18
2019-09-24 	seqlock, kcsan: Add annotations for KCSAN <https://git.kernel.org/pub/scm/linux/kernel/git/mark/linux.git/commit/?h=arm64/kcsan&id=e2b32e1a3b397bffcb6afbe86f6fe55e2040a34a>
	Marco Elver 	1 	-5/+42
2019-09-24 	build, kcsan: Add KCSAN build exceptions <https://git.kernel.org/pub/scm/linux/kernel/git/mark/linux.git/commit/?h=arm64/kcsan&id=35a907033244099a71f17d28e9ffaca92f714463>
	Marco Elver 	3 	-0/+17
2019-09-24 	objtool, kcsan: Add KCSAN runtime functions to whitelist <https://git.kernel.org/pub/scm/linux/kernel/git/mark/linux.git/commit/?h=arm64/kcsan&id=3afc592ca7ebd9c13c939c98b995763345e85e08>
	Marco Elver 	1 	-0/+17

2019-09-24 kcsan: Add Kernel Concurrency Sanitizer infrastructure <https://git.kernel.org/pub/scm/linux/kernel/git/mark/linux.git/commit/?h=arm64/kcsan&id=73d893b441dc3e5c1645884a19b46a1bfd4fd692>
Marco Elver