Skip to contentSkip to conversation

video: arkfb: use DEFINE_PCI_DEVICE_TABLE macro

PATCH In review Jingoo Han 1 participant 2 messages Nov 28, 2013 Framebuffer layer

lore
Share & tools
lore

Jingoo Han

author
#0 lore raw

PATCH 1/28 video: arkfb: use DEFINE_PCI_DEVICE_TABLE macro

This macro is used to create a struct pci_device_id array.

---
 drivers/video/arkfb.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/video/arkfb.c +1 -1
index a6b29bd..cc9f8a2 100644
@@ -1183,7 +1183,7 @@ fail:
 
 /* List of boards that we are trying to support */
 
-static struct pci_device_id ark_devices[] = {
+static DEFINE_PCI_DEVICE_TABLE(ark_devices) = {
 	{PCI_DEVICE(0xEDD8, 0xA099)},
 	{0, 0, 0, 0, 0, 0, 0}
 };
Signature · 1 line
1.7.10.4
author
#1 lore raw

On Thursday, November 28, 2013 12:13 PM, Jingoo Han

Quoted 4 lines

This macro is used to create a struct pci_device_id array.

Please, ignore these patches.
According to the Greg Kroah-Hartman,

"Yeah, and it's a horrid macro that deserves to be removed, please don't use it in more places.

Actually, if you could just remove it, that would be best, sorry, I'm not going to take these patches."

So, I will send the patch to remove 'DEFINE_PCI_DEVICE_TABLE' instead. Sorry for annoying. :-)

Best regards,
Jingoo Han

Quoted 19 lines
---
 drivers/video/arkfb.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/video/arkfb.c +1 -2
index a6b29bd..cc9f8a2 100644
@@ -1183,7 +1183,7 @@ fail:
 
 /* List of boards that we are trying to support */
 
-static struct pci_device_id ark_devices[] = {
+static DEFINE_PCI_DEVICE_TABLE(ark_devices) = {
 	{PCI_DEVICE(0xEDD8, 0xA099)},
 	{0, 0, 0, 0, 0, 0, 0}
 };
--

1.7.10.4