net: ethernet: smsc: remove unnecessary platform_set_drvdata()
PATCH 26/36 net: ethernet: smsc: remove unnecessary platform_set_drvdata()
The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.
Signed-off-by Jingoo Han <[email protected]>
--- drivers/net/ethernet/smsc/smc911x.c | 2 -- drivers/net/ethernet/smsc/smc91x.c | 3 --- drivers/net/ethernet/smsc/smsc911x.c | 2 -- 3 files changed, 0 insertions(+), 7 deletions(-)
drivers/net/ethernet/smsc/smc911x.c +0 -2
@@ -2087,7 +2087,6 @@ static int smc911x_drv_probe(struct platform_device *pdev) ndev->base_addr = res->start; ret =smc911x_probe (ndev);if (ret !=0 ) { -platform_set_drvdata (pdev,NULL );iounmap (addr); release_both:free_netdev (ndev);
@@ -2113,7 +2112,6 @@ static int smc911x_drv_remove(struct platform_device *pdev)struct resource *res;DBG (SMC_DEBUG_FUNC ,"--> %s\n" , __func__); -platform_set_drvdata (pdev,NULL );unregister_netdev (ndev);
drivers/net/ethernet/smsc/smc91x.c +0 -3
@@ -2299,7 +2299,6 @@ static int smc_drv_probe(struct platform_device *pdev)return 0 ; out_iounmap: -platform_set_drvdata (pdev,NULL );iounmap (addr); out_release_attrib:smc_release_attrib (pdev, ndev);
@@ -2319,8 +2318,6 @@ static int smc_drv_remove(struct platform_device *pdev)struct smc_local *lp =netdev_priv (ndev);struct resource *res; -platform_set_drvdata (pdev,NULL ); -unregister_netdev (ndev);free_irq (ndev->irq, ndev);
drivers/net/ethernet/smsc/smsc911x.c +0 -2
@@ -2284,7 +2284,6 @@ static int smsc911x_drv_remove(struct platform_device *pdev)mdiobus_unregister (pdata->mii_bus);mdiobus_free (pdata->mii_bus); -platform_set_drvdata (pdev,NULL );unregister_netdev (dev);free_irq (dev->irq, dev); res = platform_get_resource_byname(pdev, IORESOURCE_MEM,
@@ -2539,7 +2538,6 @@ out_disable_resources: out_enable_resources_fail:smsc911x_free_resources (pdev); out_request_resources_fail: -platform_set_drvdata (pdev,NULL );iounmap (pdata->ioaddr);free_netdev (dev); out_release_io_1:
Signature · 1 line
1.7.2.5