Skip to contentSkip to conversation

mfd: lpc_ich: Staticize struct 'lpc_chipset_info'

PATCH Applied Jingoo Han 2 participants 2 messages Aug 1, 2013

Subsystems (2)
Multifunction devices (MFD) Ich lpc and GPIO driver
lore
Share & tools
lore

Jingoo Han

author
#0 lore raw

PATCH 1/1 mfd: lpc_ich: Staticize struct 'lpc_chipset_info'

'lpc_chipset_info' is used only in this file.

Fix the following sparse warning:

drivers/mfd/lpc_ich.c:216:21: warning: symbol 'lpc_chipset_info' was not declared. Should it be static?

Signed-off-by Jingoo Han <[email protected]>
---
 drivers/mfd/lpc_ich.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mfd/lpc_ich.c +1 -1
index 2403332..9483bc8 100644
@@ -213,7 +213,7 @@ enum lpc_chipsets {
 	LPC_COLETO,	/* Coleto Creek */
 };
 
-struct lpc_ich_info lpc_chipset_info[] = {
+static struct lpc_ich_info lpc_chipset_info[] = {
 	[LPC_ICH] = {
 		.name = "ICH",
 		.iTCO_version = 1,
Signature · 1 line
1.7.10.4
Applied
#1 lore raw
Quoted 16 lines · Jingoo Han

'lpc_chipset_info' is used only in this file.

Fix the following sparse warning:

drivers/mfd/lpc_ich.c:216:21: warning: symbol 'lpc_chipset_info' was not declared. Should it be static?

Signed-off-by Jingoo Han <[email protected]>
---
 drivers/mfd/lpc_ich.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mfd/lpc_ich.c +0 -0
index 2403332..9483bc8 100644

drivers/mfd/lpc_ich.c enum lpc_chipsets { · line 219

Quoted 8 lines
drivers/mfd/lpc_ich.c +1 -1
@@ -213,7 +213,7 @@ enum lpc_chipsets {
 	LPC_COLETO,	/* Coleto Creek */
 };
 
-struct lpc_ich_info lpc_chipset_info[] = {
+static struct lpc_ich_info lpc_chipset_info[] = {
 	[LPC_ICH] = {
 		.name = "ICH",
 		.iTCO_version = 1,

Applied, thanks.

Signature · 4 lines
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog