rtc: rtc-sa1100: remove unnecessary platform_set_drvdata()
PATCH 32/42 rtc: rtc-sa1100: remove unnecessary platform_set_drvdata()
The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.
Signed-off-by Jingoo Han <[email protected]>
--- drivers/rtc/rtc-sa1100.c | 8 ++------ 1 files changed, 2 insertions(+), 6 deletions(-)
drivers/rtc/rtc-sa1100.c +2 -6
@@ -249,7 +249,7 @@ static int sa1100_rtc_probe(struct platform_device *pdev) ret =clk_prepare_enable (info->clk);if (ret) - goto err_enable_clk; +return ret;/* * According to the manual we should be able to let RTTR be zero * and then a default diviser for a 32.768KHz clock is used.
@@ -303,8 +303,6 @@ static int sa1100_rtc_probe(struct platform_device *pdev)return 0 ; err_dev:clk_disable_unprepare (info->clk); -err_enable_clk: -platform_set_drvdata (pdev,NULL );return ret; }
@@ -312,10 +310,8 @@ static int sa1100_rtc_remove(struct platform_device *pdev) {struct sa1100_rtc *info =platform_get_drvdata (pdev); -if (info) { +if (info)clk_disable_unprepare (info->clk); -platform_set_drvdata (pdev,NULL ); - }return 0 ; }
Signature · 1 line
1.7.2.5