w1: w1-gpio: use dev_get_platdata()
PATCH 1/2 w1: w1-gpio: use dev_get_platdata()
Use the wrapper function for retrieving the platform data instead of accessing dev->platform_data directly. This is a cosmetic change to make the code simpler and enhance the readability.
Signed-off-by Jingoo Han <[email protected]>
--- drivers/w1/masters/w1-gpio.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/w1/masters/w1-gpio.c +5 -5
@@ -56,7 +56,7 @@ MODULE_DEVICE_TABLE(of, w1_gpio_dt_ids);static int w1_gpio_probe_dt (struct platform_device *pdev) { -struct w1_gpio_platform_data *pdata = pdev->dev.platform_data; +struct w1_gpio_platform_data *pdata =dev_get_platdata (&pdev->dev);struct device_node *np = pdev->dev.of_node; pdata =devm_kzalloc (&pdev->dev,sizeof (*pdata),GFP_KERNEL );
@@ -87,7 +87,7 @@ static int w1_gpio_probe(struct platform_device *pdev) } } - pdata = pdev->dev.platform_data; + pdata =dev_get_platdata (&pdev->dev);if (!pdata) {dev_err (&pdev->dev,"No configuration data\n" );
@@ -157,7 +157,7 @@ static int w1_gpio_probe(struct platform_device *pdev)static int w1_gpio_remove (struct platform_device *pdev) {struct w1_bus_master *master =platform_get_drvdata (pdev); -struct w1_gpio_platform_data *pdata = pdev->dev.platform_data; +struct w1_gpio_platform_data *pdata =dev_get_platdata (&pdev->dev);if (pdata->enable_external_pullup) pdata->enable_external_pullup (0 );
@@ -176,7 +176,7 @@ static int w1_gpio_remove(struct platform_device *pdev)static int w1_gpio_suspend (struct platform_device *pdev,pm_message_t state) { -struct w1_gpio_platform_data *pdata = pdev->dev.platform_data; +struct w1_gpio_platform_data *pdata =dev_get_platdata (&pdev->dev);if (pdata->enable_external_pullup) pdata->enable_external_pullup (0 );
@@ -186,7 +186,7 @@ static int w1_gpio_suspend(struct platform_device *pdev, pm_message_t state)static int w1_gpio_resume (struct platform_device *pdev) { -struct w1_gpio_platform_data *pdata = pdev->dev.platform_data; +struct w1_gpio_platform_data *pdata =dev_get_platdata (&pdev->dev);if (pdata->enable_external_pullup) pdata->enable_external_pullup (1 );
Signature · 1 line
1.7.10.4
PATCH 2/2 w1: ds1wm: use dev_get_platdata()
Use the wrapper function for retrieving the platform data instead of accessing dev->platform_data directly. This is a cosmetic change to make the code simpler and enhance the readability.
Signed-off-by Jingoo Han <[email protected]>
--- drivers/w1/masters/ds1wm.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
drivers/w1/masters/ds1wm.c +6 -6
@@ -255,17 +255,17 @@ static int ds1wm_find_divisor(int gclk)static void ds1wm_up (struct ds1wm_data *ds1wm_data) {int divisor; -struct ds1wm_driver_data *plat = ds1wm_data->pdev->dev.platform_data; +struct device *dev = &ds1wm_data->pdev->dev; +struct ds1wm_driver_data *plat =dev_get_platdata (dev);if (ds1wm_data->cell->enable) ds1wm_data->cell->enable (ds1wm_data->pdev); divisor =ds1wm_find_divisor (plat->clock_rate); -dev_dbg (&ds1wm_data->pdev->dev, -"found divisor 0x%x for clock %d\n" , divisor, plat->clock_rate); +dev_dbg (dev,"found divisor 0x%x for clock %d\n" , + divisor, plat->clock_rate);if (divisor ==0 ) { -dev_err (&ds1wm_data->pdev->dev, -"no suitable divisor for %dHz clock\n" , +dev_err (dev,"no suitable divisor for %dHz clock\n" , plat->clock_rate);return ; }
@@ -481,7 +481,7 @@ static int ds1wm_probe(struct platform_device *pdev) ds1wm_data->cell =mfd_get_cell (pdev);if (!ds1wm_data->cell)return -ENODEV ; - plat = pdev->dev.platform_data; + plat =dev_get_platdata (&pdev->dev);if (!plat)return -ENODEV ;
Signature · 1 line
1.7.10.4
Hi
30.08.2013, 08:17, "Jingoo Han" <[email protected]>:
Quoted 3 lines
Use the wrapper function for retrieving the platform data instead of accessing
dev->platform_datadirectly. This is a cosmetic change to make the code simpler and enhance the readability.
Both patches look good, thank you
Quoted 1 line
Signed-off-by Jingoo Han <[email protected]>
Acked-by Evgeniy Polyakov <[email protected]>