f2fs: fix to truncate blocks past EOF in ->setattr
PATCH 2/5 f2fs: fix to truncate blocks past EOF in ->setattr
By using FALLOC_FL_KEEP_SIZE in ->fallocate of f2fs, we can fallocate block past EOF without changing i_size of inode. These blocks past EOF will not be truncated in ->setattr as we truncate them only when change the file size.
We should give a chance to truncate blocks out of filesize in setattr().
Signed-off-by Chao Yu <[email protected]>
--- fs/f2fs/file.c | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-)
fs/f2fs/file.c +12 -5
@@ -547,15 +547,22 @@ int f2fs_setattr(struct dentry *dentry, struct iattr *attr)if (err)return err; -if ((attr->ia_valid &ATTR_SIZE ) && - attr->ia_size !=i_size_read (inode)) { +if (attr->ia_valid &ATTR_SIZE ) { err =f2fs_convert_inline_data (inode, attr->ia_size,NULL );if (err)return err; -truncate_setsize (inode, attr->ia_size); -f2fs_truncate (inode); -f2fs_balance_fs (F2FS_I_SB (inode)); +if (attr->ia_size !=i_size_read (inode)) { +truncate_setsize (inode, attr->ia_size); +f2fs_truncate (inode); +f2fs_balance_fs (F2FS_I_SB (inode)); + }else { +/* +* giving a chance to truncate blocks past EOF which +* are fallocated with FALLOC_FL_KEEP_SIZE. +*/ +f2fs_truncate (inode); + } }__setattr_copy (inode, attr);
Signature · 1 line
2.0.1.474.g72c7794