Skip to contentSkip to conversation

ARM: dts: add DP clock reference to exynos5250 device tree

PATCH Applied Jingoo Han 3 participants 3 messages May 11, 2013 – Jun 5, 2013 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore

Jingoo Han

author
#0 lore raw

PATCH 1/2 ARM: dts: add DP clock reference to exynos5250 device tree

The transition to common clock happened; however, DP (Display Port) clock node was not added. Thus, DP (Display Port) clock node should be added to the device tree.

---
Tested on Exynos5250

 arch/arm/boot/dts/exynos5250.dtsi |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
arch/arm/boot/dts/exynos5250.dtsi +2 -0
index 9dfc6de..8b1f9b6 100644
@@ -651,6 +651,8 @@
 		reg = <0x145b0000 0x1000>;
 		interrupts = <10 3>;
 		interrupt-parent = <&combiner>;
+		clocks = <&clock 342>;
+		clock-names = "dp";
 		#address-cells = <1>;
 		#size-cells = <0>;
 
Signature · 1 line
1.7.2.5
Reviewed-by on v1 1/2
#1 lore raw

Jingoo,

Quoted 10 lines · Jingoo Han

The transition to common clock happened; however, DP (Display Port) clock node was not added. Thus, DP (Display Port) clock node should be added to the device tree.

---
Tested on Exynos5250

 arch/arm/boot/dts/exynos5250.dtsi |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

Clock number matches clock bindings for 5250 and clock name matches dp driver, so this looks good.

A message that is not in the archive (sent off-list or not yet received): CAGm_ybh_Uvs2dX3Ecgcwy=GFO6QH-Hj1jz3f1=cDbZGq0Q4qDQ@mail.gmail.com

#3 lore raw
Quoted 14 lines · Vikas Sajjan

Hi Mr. Jingoo Han,

On Sat, May 11, 2013 at 1:12 PM, Jingoo Han <[email protected]> wrote:
The transition to common clock happened; however, DP (Display Port) clock node was not added. Thus, DP (Display Port) clock node should be added to the device tree.

---
Tested on Exynos5250

?arch/arm/boot/dts/exynos5250.dtsi | ? ?2 ++
?1 files changed, 2 insertions(+), 0 deletions(-)

[...]

Quoted 3 lines

?I have already sent similar patch on 8th May 2013.

http://www.spinics.net/lists/linux-samsung-soc/msg18136.html

Vikas, please don't use html typed e-mail :-(

OK, I found Jingoo's ack on that.

Let me take that with Jingoo's ack and Doug's review tag.

Thanks.

- Kukjin