Skip to contentSkip to conversation

tools/power turbostat: Print cpuidle information

PATCH In review Len Brown 2 participants 3 messages Mar 21, 2020 – Aug 13, 2020 1 message not in the archive Turbostat utility

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): 081c54323b27d8d4b40df6b2375b9e1f6846d827.1584766216.git.len.brown@intel.com

Len Brown

author maintainer
#1 lore raw

PATCH v2 9/10 tools/power turbostat: Print cpuidle information

From: Len Brown <[email protected]>

Print cpuidle driver and governor.

---
 tools/power/x86/turbostat/turbostat.c | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)
tools/power/x86/turbostat/turbostat.c +26 -0
index 77f89371ec5f..05dbe23570d4 100644
@@ -3503,6 +3503,23 @@ dump_cstate_pstate_config_info(unsigned int family, unsigned int model)
 	dump_nhm_cst_cfg();
 }
 
+static void dump_sysfs_file(char *path)
+{
+	FILE *input;
+	char cpuidle_buf[64];
+
+	input = fopen(path, "r");
+	if (input == NULL) {
+		if (debug)
+			fprintf(outf, "NSFOD %s\n", path);
+		return;
+	}
+	if (!fgets(cpuidle_buf, sizeof(cpuidle_buf), input))
+		err(1, "%s: failed to read file", path);
+	fclose(input);
+
+	fprintf(outf, "%s: %s", strrchr(path, '/') + 1, cpuidle_buf);
+}
 static void
 dump_sysfs_cstate_config(void)
 {
@@ -3516,6 +3533,15 @@ dump_sysfs_cstate_config(void)
 	if (!DO_BIC(BIC_sysfs))
 		return;
 
+	if (access("/sys/devices/system/cpu/cpuidle", R_OK)) {
+		fprintf(outf, "cpuidle not loaded\n");
+		return;
+	}
+
+	dump_sysfs_file("/sys/devices/system/cpu/cpuidle/current_driver");
+	dump_sysfs_file("/sys/devices/system/cpu/cpuidle/current_governor");
+	dump_sysfs_file("/sys/devices/system/cpu/cpuidle/current_governor_ro");
+
 	for (state = 0; state < 10; ++state) {
 
 		sprintf(path, "/sys/devices/system/cpu/cpu%d/cpuidle/state%d/name",
Signature · 1 line
2.20.1
#2 lore raw

Hi Len,

Quoted 14 lines · On 2020.03.20 21:55 Len Brown wrote:

From: Len Brown <[email protected]>

Print cpuidle driver and governor.

---
tools/power/x86/turbostat/turbostat.c | 26 ++++++++++++++++++++++++++

1 file changed, 26 insertions(+)
tools/power/x86/turbostat/turbostat.c +0 -0
index 77f89371ec5f..05dbe23570d4 100644

...

tools/power/x86/turbostat/turbostat.c dump_sysfs_cstate_config(void) · line 3534

Quoted 7 lines

static void
dump_sysfs_cstate_config(void)
{

tools/power/x86/turbostat/turbostat.c +0 -0
@@ -3516,6 +3533,15 @@ dump_sysfs_cstate_config(void)
 	if (!DO_BIC(BIC_sysfs))
 		return;

I do not understand why this information needs to be a function of the --show options and not solely a function of the --quiet option.

My reasoning is that I almost always want all the information possible in the start spew of stuff, and if I don't I'll use --quiet option. However, I rarely show more than about 6 columns at a time resulting in intermittent inclusion of this information.

Quoted 13 lines
tools/power/x86/turbostat/turbostat.c +9 -0
+	if (access("/sys/devices/system/cpu/cpuidle", R_OK)) {
+		fprintf(outf, "cpuidle not loaded\n");
+		return;
+	}
+
+	dump_sysfs_file("/sys/devices/system/cpu/cpuidle/current_driver");
+	dump_sysfs_file("/sys/devices/system/cpu/cpuidle/current_governor");
+	dump_sysfs_file("/sys/devices/system/cpu/cpuidle/current_governor_ro");
+
 	for (state = 0; state < 10; ++state) {
 
 		sprintf(path, "/sys/devices/system/cpu/cpu%d/cpuidle/state%d/name",
author maintainer
#3 lore raw

Doug,
I agree with you.

Looks like an oversight -- will fix.

thanks!
-Len

Quoted 56 lines · Doug Smythies

Hi Len,

Quoted 14 lines · On 2020.03.20 21:55 Len Brown wrote:

From: Len Brown <[email protected]>

Print cpuidle driver and governor.

---
tools/power/x86/turbostat/turbostat.c | 26 ++++++++++++++++++++++++++

1 file changed, 26 insertions(+)
tools/power/x86/turbostat/turbostat.c +0 -0
index 77f89371ec5f..05dbe23570d4 100644

...

tools/power/x86/turbostat/turbostat.c dump_sysfs_cstate_config(void) · line 3534

Quoted 7 lines

static void
dump_sysfs_cstate_config(void)
{

tools/power/x86/turbostat/turbostat.c +0 -0
@@ -3516,6 +3533,15 @@ dump_sysfs_cstate_config(void)
      if (!DO_BIC(BIC_sysfs))
              return;

I do not understand why this information needs to be a function of the --show options and not solely a function of the --quiet option.

My reasoning is that I almost always want all the information possible in the start spew of stuff, and if I don't I'll use --quiet option. However, I rarely show more than about 6 columns at a time resulting in intermittent inclusion of this information.

Quoted 13 lines
tools/power/x86/turbostat/turbostat.c +9 -0
+     if (access("/sys/devices/system/cpu/cpuidle", R_OK)) {
+             fprintf(outf, "cpuidle not loaded\n");
+             return;
+     }
+
+     dump_sysfs_file("/sys/devices/system/cpu/cpuidle/current_driver");
+     dump_sysfs_file("/sys/devices/system/cpu/cpuidle/current_governor");
+     dump_sysfs_file("/sys/devices/system/cpu/cpuidle/current_governor_ro");
+
      for (state = 0; state < 10; ++state) {
 
              sprintf(path, "/sys/devices/system/cpu/cpu%d/cpuidle/state%d/name",
Signature · 1 line
Len Brown, Intel Open Source Technology Center