Skip to contentSkip to conversation

ARM: EXYNOS: Remove wrong I2S0 clock from peril clock

PATCH New Sangsu Park 2 participants 3 messages Sep 28, 2012 – Jan 16, 2013

Subsystems (3)
Arm (32-bit) Arm sub-architectures Arm Samsung Exynos
lore
Share & tools
lore

Sangsu Park

author
#0 lore raw

PATCH 1/1 ARM: EXYNOS: Remove wrong I2S0 clock from peril clock

Remove I2S0 clock from peril since peril doesn't have I2S0 clock for EXYNOS4. Audio Subsystem block has I2S0 clk.

Signed-off-by sangsu <sangsu@sangsu-P560.(none)>
---
 arch/arm/mach-exynos/clock-exynos4.c |    5 -----
 1 file changed, 5 deletions(-)
(quoted diff) +0 -0

b/arch/arm/mach-exynos/clock-exynos4.c
index 6a45c9a..fa8a134 100644

arch/arm/mach-exynos/clock-exynos4.c +0 -5
@@ -613,11 +613,6 @@ static struct clk exynos4_init_clocks_off[] = {
 		.ctrlbit	= (1 << 18),
 	}, {
 		.name		= "iis",
-		.devname	= "samsung-i2s.0",
-		.enable		= exynos4_clk_ip_peril_ctrl,
-		.ctrlbit	= (1 << 19),
-	}, {
-		.name		= "iis",
 		.devname	= "samsung-i2s.1",
 		.enable		= exynos4_clk_ip_peril_ctrl,
 		.ctrlbit	= (1 << 20),
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 ARM: EXYNOS: Remove wrong I2S0 clock from peril clock

Quoted 16 lines · Sangsu Park

Remove I2S0 clock from peril since peril doesn't have I2S0 clock for EXYNOS4. Audio Subsystem block has I2S0 clk.

Signed-off-by sangsu <sangsu@sangsu-P560.(none)>
---
 arch/arm/mach-exynos/clock-exynos4.c |    5 -----
 1 file changed, 5 deletions(-)
arch/arm/mach-exynos/clock-exynos4.c +0 -0
index 6a45c9a..fa8a134 100644
@@ -613,11 +613,6 @@ static struct clk exynos4_init_clocks_off[] = {
 		.ctrlbit	= (1 << 18),

arch/arm/mach-exynos/clock-exynos4.c static struct clk exynos4_init_clocks_off[] = { · line 618

Quoted 10 lines
arch/arm/mach-exynos/clock-exynos4.c +0 -5
 	}, {
 		.name		= "iis",
-		.devname	= "samsung-i2s.0",
-		.enable		= exynos4_clk_ip_peril_ctrl,
-		.ctrlbit	= (1 << 19),
-	}, {
-		.name		= "iis",
 		.devname	= "samsung-i2s.1",
 		.enable		= exynos4_clk_ip_peril_ctrl,
 		.ctrlbit	= (1 << 20),

After this clock has been removed, I2S0 registration fails on EXYNOS4 based boards (clk_get for iis clock fails). The alternate clock from Audio subsystem block is missing.

Signature · 1 line
Tushar Behera
author
#2 lore raw

PATCH 1/1 ARM: EXYNOS: Remove wrong I2S0 clock from peril clock

Quoted 2 lines · Tushar Behera
Quoted 1 line · Sangsu Park

Remove I2S0 clock from peril since peril doesn't have I2S0 clock for

EXYNOS4.

Quoted 21 lines
Quoted 21 lines

Audio Subsystem block has I2S0 clk.

Signed-off-by sangsu <sangsu@sangsu-P560.(none)>
---
 arch/arm/mach-exynos/clock-exynos4.c |    5 -----
 1 file changed, 5 deletions(-)
arch/arm/mach-exynos/clock-exynos4.c +0 -5
index 6a45c9a..fa8a134 100644
@@ -613,11 +613,6 @@ static struct clk exynos4_init_clocks_off[] = {
 		.ctrlbit	= (1 << 18),
 	}, {
 		.name		= "iis",
-		.devname	= "samsung-i2s.0",
-		.enable		= exynos4_clk_ip_peril_ctrl,
-		.ctrlbit	= (1 << 19),
-	}, {
-		.name		= "iis",
Quoted 9 lines

arch/arm/mach-exynos/clock-exynos4.c static struct clk exynos4_init_clocks_off[] = { · line 618

Quoted 4 lines
arch/arm/mach-exynos/clock-exynos4.c +0 -0
 		.devname	= "samsung-i2s.1",
 		.enable		= exynos4_clk_ip_peril_ctrl,
 		.ctrlbit	= (1 << 20),

After this clock has been removed, I2S0 registration fails on EXYNOS4 based boards (clk_get for iis clock fails). The alternate clock from Audio subsystem block is missing.

Yes, you're right.
I2S0 clock doesn't belong to peril clock. Audio Subsystem has its own clock and also I2S0 clock. That work might be missed. I'll do that work soon.

Thanks.

Quoted 2 lines

--
Tushar Behera