ext4: remove unneeded code in ext4_unlink

PATCH Applied Namjae Jeon 2 participants 2 messages Nov 24, 2014 – Nov 25, 2014 ext4 file system

lore

Share & tools

lore

Namjae Jeon

author

2014-11-24 06:43 UTC #0 lore raw

PATCH 1/1 ext4: remove unneeded code in ext4_unlink

Setting retval to zero is not needed in ext4_unlink. Remove unneeded code.

Signed-off-by Namjae Jeon <[email protected]>

Signed-off-by Ashish Sangwan <[email protected]>

---
 fs/ext4/namei.c | 1 -
 1 file changed, 1 deletion(-)

fs/ext4/namei.c +0 -1

index 4262118..2291923 100644
@@ -2814,7 +2814,6 @@ static int ext4_unlink(struct inode *dir, struct dentry *dentry)
 		ext4_orphan_add(handle, inode);
 	inode->i_ctime = ext4_current_time(inode);
 	ext4_mark_inode_dirty(handle, inode);
-	retval = 0;
 
 end_unlink:
 	brelse(bh);

Signature · 1 line

1.7.11-rc0

Theodore Ts'o

maintainer Applied

2014-11-25 21:47 UTC #1 lore raw

Quoted 5 lines · Namjae Jeon

Setting retval to zero is not needed in ext4_unlink. Remove unneeded code.
Signed-off-by Namjae Jeon <[email protected]>
Signed-off-by Ashish Sangwan <[email protected]>

Thanks, applied.

- Ted