misc: arm-charlcd: remove unnecessary platform_set_drvdata()
PATCH 1/2 misc: arm-charlcd: remove unnecessary platform_set_drvdata()
The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.
Signed-off-by Jingoo Han <[email protected]>
--- drivers/misc/arm-charlcd.c | 5 +---- 1 files changed, 1 insertions(+), 4 deletions(-)
drivers/misc/arm-charlcd.c +1 -4
@@ -291,7 +291,7 @@ static int __init charlcd_probe(struct platform_device *pdev) lcd->virtbase =ioremap (lcd->phybase, lcd->physize);if (!lcd->virtbase) { ret = -ENOMEM ; - goto out_no_remap; + goto out_no_memregion; } lcd->irq =platform_get_irq (pdev,0 );
@@ -320,8 +320,6 @@ static int __init charlcd_probe(struct platform_device *pdev) out_no_irq:iounmap (lcd->virtbase); -out_no_remap: -platform_set_drvdata (pdev,NULL ); out_no_memregion:release_mem_region (lcd->phybase,SZ_4K ); out_no_resource:
@@ -337,7 +335,6 @@ static int __exit charlcd_remove(struct platform_device *pdev)free_irq (lcd->irq, lcd);iounmap (lcd->virtbase);release_mem_region (lcd->phybase, lcd->physize); -platform_set_drvdata (pdev,NULL );kfree (lcd); }
Signature · 1 line
1.7.2.5
Quoted 6 lines · Jingoo Han
The driver core clears the driver data to NULL after
device_releaseor on probe failure, since commit0998d0631001288a5974afc0b2a5f568bcdecb4d(device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.Signed-off-by Jingoo Han <[email protected]>
Acked-by Linus Walleij <[email protected]>
Yours,
Linus Walleij