ab8500_bm: remove unnecessary platform_set_drvdata()
PATCH 3/8 ab8500_bm: remove unnecessary platform_set_drvdata()
The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.
Signed-off-by Jingoo Han <[email protected]>
--- drivers/power/ab8500_btemp.c | 1 - drivers/power/ab8500_charger.c | 2 -- drivers/power/ab8500_fg.c | 1 - drivers/power/abx500_chargalg.c | 1 - 4 files changed, 0 insertions(+), 5 deletions(-)
drivers/power/ab8500_btemp.c +0 -1
@@ -1045,7 +1045,6 @@ static int ab8500_btemp_remove(struct platform_device *pdev)flush_scheduled_work ();power_supply_unregister (&di->btemp_psy); -platform_set_drvdata (pdev,NULL );return 0 ; }
drivers/power/ab8500_charger.c +0 -2
@@ -3425,8 +3425,6 @@ static int ab8500_charger_remove(struct platform_device *pdev)if (di->ac_chg.enabled && !di->ac_chg.external)power_supply_unregister (&di->ac_chg.psy); -platform_set_drvdata (pdev,NULL ); -return 0 ; }
drivers/power/ab8500_fg.c +0 -1
@@ -3070,7 +3070,6 @@ static int ab8500_fg_remove(struct platform_device *pdev)flush_scheduled_work ();ab8500_fg_sysfs_psy_remove_attrs (di->fg_psy.dev);power_supply_unregister (&di->fg_psy); -platform_set_drvdata (pdev,NULL );return ret; }
drivers/power/abx500_chargalg.c +0 -1
@@ -2035,7 +2035,6 @@ static int abx500_chargalg_remove(struct platform_device *pdev)destroy_workqueue (di->chargalg_wq);power_supply_unregister (&di->chargalg_psy); -platform_set_drvdata (pdev,NULL );return 0 ; }
Signature · 1 line
1.7.2.5
Quoted 5 lines · Jingoo Han
The driver core clears the driver data to NULL after
device_releaseor on probe failure, since commit0998d0631001288a5974afc0b2a5f568bcdecb4d(device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.
Quoted 7 lines
Signed-off-by Jingoo Han <[email protected]>--- drivers/power/ab8500_btemp.c | 1 - drivers/power/ab8500_charger.c | 2 -- drivers/power/ab8500_fg.c | 1 - drivers/power/abx500_chargalg.c | 1 - 4 files changed, 0 insertions(+), 5 deletions(-)
Acked-by Lee Jones <[email protected]>
Signature · 4 lines
Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog