Skip to contentSkip to conversation

misc: ep93xx_pwm: remove unnecessary platform_set_drvdata()

PATCH In review Jingoo Han 2 participants 2 messages May 7, 2013 – May 14, 2013 Char and misc drivers

lore
Share & tools
lore

Jingoo Han

author
#0 lore raw

PATCH 2/2 misc: ep93xx_pwm: remove unnecessary platform_set_drvdata()

The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.

---
 drivers/misc/ep93xx_pwm.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/misc/ep93xx_pwm.c +0 -1
index 96787ec..9ba93f0 100644
@@ -347,7 +347,6 @@ static int __exit ep93xx_pwm_remove(struct platform_device *pdev)
 	ep93xx_pwm_disable(pwm);
 	clk_disable(pwm->clk);
 	clk_put(pwm->clk);
-	platform_set_drvdata(pdev, NULL);
 	sysfs_remove_group(&pdev->dev.kobj, &ep93xx_pwm_sysfs_files);
 	iounmap(pwm->mmio_base);
 	release_mem_region(res->start, resource_size(res));
Signature · 1 line
1.7.2.5
Reviewed-by on v1 2/2
#1 lore raw
Quoted 9 lines · Jingoo Han

The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.

---
 drivers/misc/ep93xx_pwm.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)