Skip to contentSkip to conversation

iw: avgerage ack rssi changes for data frames

PATCH In review Balaji Pothunoori 2 participants 4 messages Mar 8, 2018 – May 23, 2018

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 iw: avgerage ack rssi changes for data frames

This patch is to display the average ack rssi for data frames. "avg ack signal" field diplay limited by host based on firmware capablities.

Example output:

localhost ~ #iw dev wlan-5000mhz station dump
Station 34:f3:9a:aa:3b:29 (on wlan-5000mhz)

        inactive time:  5370 ms
        rx bytes:       85321
        rx packets:     576
        tx bytes:       14225
        tx packets:     71
        tx retries:     0
        tx failed:      2
        beacon loss:    0
        rx drop misc:   0
        signal:         -54 dBm
        signal avg:     -53 dBm
        tx bitrate:     866.7 MBit/s VHT-MCS 9 80MHz short GI VHT-NSS 2
        rx bitrate:     866.7 MBit/s VHT-MCS 9 80MHz short GI VHT-NSS 2

avg ack signal: -56 dBm
authorized: yes
authenticated: yes
associated: yes
preamble: short
WMM/WME: yes
MFP: no
TDLS peer: no
DTIM period: 2
beacon interval:100
short preamble: yes
short slot time:yes
connected time: 203 seconds

---
V2:
-Removed nl80211.h changes and modified the commit log.
V3:
-Adding version.

---
 station.c | 4 ++++
 1 file changed, 4 insertions(+)
station.c +4 -0
index f3e3da8..6c567bc 100644
@@ -237,6 +237,7 @@ static int print_sta_handler(struct nl_msg *msg, void *arg)
 		[NL80211_STA_INFO_TID_STATS] = { .type = NLA_NESTED },
 		[NL80211_STA_INFO_BSS_PARAM] = { .type = NLA_NESTED },
 		[NL80211_STA_INFO_RX_DURATION] = { .type = NLA_U64 },
+		[NL80211_STA_INFO_DATA_AVG_ACK_SIGNAL] = { .type = NLA_U8 },
 	};
 	char *chain;
 
@@ -338,6 +339,9 @@ static int print_sta_handler(struct nl_msg *msg, void *arg)
 		printf("\n\trx duration:\t%lld us",
 		       (unsigned long long)nla_get_u64(sinfo[NL80211_STA_INFO_RX_DURATION]));
 
+	if (sinfo[NL80211_STA_INFO_DATA_AVG_ACK_SIGNAL])
+		printf("\n\tavg ack signal:\t%d dBm",
+		       (int8_t)nla_get_u8(sinfo[NL80211_STA_INFO_DATA_AVG_ACK_SIGNAL]));
 	if (sinfo[NL80211_STA_INFO_EXPECTED_THROUGHPUT]) {
 		uint32_t thr;
 
Signature · 1 line
2.7.4
#1 lore raw
Quoted 3 lines · Balaji Pothunoori

This patch is to display the average ack rssi for data frames. "avg ack signal" field diplay limited by host based on firmware capablities.

I no longer have a corresponding kernel patch pending, so this is useless?

johannes

#2 lore raw
In reply to Balaji Pothunoori
Quoted 3 lines · Balaji Pothunoori

This patch is to display the average ack rssi for data frames. "avg ack signal" field diplay limited by host based on firmware capablities.

This doesn't compile, please respin (and you could fix the "average" typo in the subject)

johannes

#3 lore raw

Sure Johannes, I will send another version of patch.

Quoted 9 lines · Johannes Berg
Quoted 3 lines · Balaji Pothunoori

This patch is to display the average ack rssi for data frames. "avg ack signal" field diplay limited by host based on firmware capablities.

This doesn't compile, please respin (and you could fix the "average" typo in the subject)

johannes