spi: altera: remove unnecessary platform_set_drvdata()

PATCH Superseded Jingoo Han 2 participants 3 messages May 3, 2013 1 message not in the archive SPI

Share & tools

Jingoo Han

author

2013-05-03 06:48 UTC #0 lore raw

PATCH 1/15 spi: altera: remove unnecessary platform_set_drvdata()

The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.

Signed-off-by Jingoo Han <[email protected]>

---
 drivers/spi/spi-altera.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

drivers/spi/spi-altera.c +0 -2

index a537f8d..81b9adb 100644
@@ -285,7 +285,6 @@ static int altera_spi_probe(struct platform_device *pdev)
 exit_busy:
 	err = -EBUSY;
 exit:
-	platform_set_drvdata(pdev, NULL);
 	spi_master_put(master);
 	return err;
 }

@@ -296,7 +295,6 @@ static int altera_spi_remove(struct platform_device *dev)
 	struct spi_master *master = hw->bitbang.master;
 
 	spi_bitbang_stop(&hw->bitbang);
-	platform_set_drvdata(dev, NULL);
 	spi_master_put(master);
 	return 0;
 }

Signature · 10 lines

1.7.2.5



------------------------------------------------------------------------------
Get 100% visibility into Java/.NET code with AppDynamics Lite
It's a free troubleshooting tool designed for production
Get down to code-level detail for bottlenecks, with <2% overhead.
Download for free and get started troubleshooting in minutes.
http://p.sf.net/sfu/appdyn_d2d_ap2

Grant Likely

Acked-by on v1 1/15

2013-05-03 07:07 UTC #1 lore raw

Quoted 6 lines · Jingoo Han

The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.
Signed-off-by Jingoo Han <[email protected]>

Hi Jingoo,

Thanks for doing this. However, there is no need to have a separate patch for each and every spi driver. Can you please squash them all into a single patch and repost?

Acked-by Grant Likely <[email protected]>

Quoted 25 lines

---
 drivers/spi/spi-altera.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

drivers/spi/spi-altera.c +0 -3

index a537f8d..81b9adb 100644
@@ -285,7 +285,6 @@ static int altera_spi_probe(struct platform_device *pdev)
 exit_busy:
        err = -EBUSY;
 exit:
-       platform_set_drvdata(pdev, NULL);
        spi_master_put(master);
        return err;
 }

@@ -296,7 +295,6 @@ static int altera_spi_remove(struct platform_device *dev)
        struct spi_master *master = hw->bitbang.master;
 
        spi_bitbang_stop(&hw->bitbang);
-       platform_set_drvdata(dev, NULL);
        spi_master_put(master);
        return 0;
 }
--

Quoted 3 lines

1.7.2.5

--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.

------------------------------------------------------------------------------
Get 100% visibility into Java/.NET code with AppDynamics Lite It's a free troubleshooting tool designed for production Get down to code-level detail for bottlenecks, with <2% overhead. Download for free and get started troubleshooting in minutes.
http://p.sf.net/sfu/appdyn_d2d_ap2

A message that is not in the archive (sent off-list or not yet received): CACxGe6vkjU_LroO9gtBY4d1wcU__Wk7n=hzo27Df5nbV6TJQvQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org

Jingoo Han

author

2013-05-03 07:16 UTC #3 lore raw

Quoted 8 lines · Grant Likely

Quoted 6 lines · Jingoo Han
The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.
Signed-off-by Jingoo Han <[email protected]>

Quoted 7 lines

Hi Jingoo,
Thanks for doing this. However, there is no need to have a separate patch for each and every spi driver. Can you please squash them all into a single patch and repost?
Acked-by Grant Likely <[email protected]>

Hi Grant,

OK, I see.
I prefer the separate patches, but I will squash them into a single patch and repost it. :)
Thank you.

Best regards,
Jingoo Han

Quoted 20 lines

---
 drivers/spi/spi-altera.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

drivers/spi/spi-altera.c +0 -1

index a537f8d..81b9adb 100644
@@ -285,7 +285,6 @@ static int altera_spi_probe(struct platform_device *pdev)
 exit_busy:
        err = -EBUSY;
 exit:
-       platform_set_drvdata(pdev, NULL);
        spi_master_put(master);
        return err;
 }

@@ -296,7 +295,6 @@ static int altera_spi_remove(struct platform_device *dev)
        struct spi_master *master = hw->bitbang.master;

Quoted 15 lines

Quoted 9 lines
drivers/spi/spi-altera.c +0 -2
        spi_bitbang_stop(&hw->bitbang);
-       platform_set_drvdata(dev, NULL);
        spi_master_put(master);
        return 0;
 }
--
1.7.2.5
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.