thermal: armada: remove unnecessary platform_set_drvdata()
Subsystems (2)
PATCH 1/6 thermal: armada: remove unnecessary platform_set_drvdata()
The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.
--- drivers/thermal/armada_thermal.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/thermal/armada_thermal.c +0 -1
@@ -210,7 +210,6 @@ static int armada_thermal_exit(struct platform_device *pdev)platform_get_drvdata (pdev);thermal_zone_device_unregister (armada_thermal); -platform_set_drvdata (pdev,NULL );return 0 ; }
Signature · 1 line
1.7.2.5
Zhang Rui
reviewerQuoted 6 lines · Jingoo Han
The driver core clears the driver data to NULL after
device_releaseor on probe failure, since commit0998d0631001288a5974afc0b2a5f568bcdecb4d(device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.Signed-off-by Jingoo Han <[email protected]>
it seems that we already have a patchset for this issue. please check https://patchwork.kernel.org/patch/2516651/
thanks,
rui
Quoted 16 lines
--- drivers/thermal/armada_thermal.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)drivers/thermal/armada_thermal.c +0
-1@@ -210,7 +210,6 @@ static int armada_thermal_exit(struct platform_device *pdev)platform_get_drvdata (pdev);thermal_zone_device_unregister (armada_thermal); -platform_set_drvdata (pdev,NULL );return 0 ; }
Quoted 10 lines · Zhang Rui
Quoted 6 lines · Jingoo Han
The driver core clears the driver data to NULL after
device_releaseor on probe failure, since commit0998d0631001288a5974afc0b2a5f568bcdecb4d(device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.Signed-off-by Jingoo Han <[email protected]>it seems that we already have a patchset for this issue. please check https://patchwork.kernel.org/patch/2516651/
OK, I see.
These patches seem to be already submitted.
Thank you.
Best regards,
Jingoo Han
Quoted 19 lines
thanks,
ruiQuoted 16 lines
--- drivers/thermal/armada_thermal.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)drivers/thermal/armada_thermal.c +0
-1@@ -210,7 +210,6 @@ static int armada_thermal_exit(struct platform_device *pdev)platform_get_drvdata (pdev);thermal_zone_device_unregister (armada_thermal); -platform_set_drvdata (pdev,NULL );return 0 ; }