Skip to contentSkip to conversation

extcon: use dev_get_platdata()

PATCH Superseded Jingoo Han 2 participants 5 messages Sep 11, 2013 External connector subsystem (extcon)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Jingoo Han

author
#0 lore raw

cover extcon: use dev_get_platdata()

Use the wrapper function for retrieving the platform data instead of accessing dev->platform_data directly. This is a cosmetic change to make the code simpler and enhance the readability.

---
 drivers/extcon/extcon-adc-jack.c |    2 +-
 drivers/extcon/extcon-gpio.c     |    2 +-
 drivers/extcon/extcon-palmas.c   |    2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
author
#1 lore raw

PATCH 1/3 extcon: adc-jack: use dev_get_platdata()

Use the wrapper function for retrieving the platform data instead of accessing dev->platform_data directly. This is a cosmetic change to make the code simpler and enhance the readability.

---
 drivers/extcon/extcon-adc-jack.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/extcon/extcon-adc-jack.c +1 -1
index 5985807..c0e0e20 100644
@@ -95,7 +95,7 @@ static irqreturn_t adc_jack_irq_thread(int irq, void *_data)
 static int adc_jack_probe(struct platform_device *pdev)
 {
 	struct adc_jack_data *data;
-	struct adc_jack_pdata *pdata = pdev->dev.platform_data;
+	struct adc_jack_pdata *pdata = dev_get_platdata(&pdev->dev);
 	int i, err = 0;
 
 	data = devm_kzalloc(&pdev->dev, sizeof(*data), GFP_KERNEL);
Signature · 1 line
1.7.10.4
author
#2 lore raw

PATCH 2/3 extcon: gpio: use dev_get_platdata()

In reply to Jingoo Han

Use the wrapper function for retrieving the platform data instead of accessing dev->platform_data directly. This is a cosmetic change to make the code simpler and enhance the readability.

---
 drivers/extcon/extcon-gpio.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/extcon/extcon-gpio.c +1 -1
index f874c30..c4d5a19 100644
@@ -78,7 +78,7 @@ static ssize_t extcon_gpio_print_state(struct extcon_dev *edev, char *buf)
 
 static int gpio_extcon_probe(struct platform_device *pdev)
 {
-	struct gpio_extcon_platform_data *pdata = pdev->dev.platform_data;
+	struct gpio_extcon_platform_data *pdata = dev_get_platdata(&pdev->dev);
 	struct gpio_extcon_data *extcon_data;
 	int ret = 0;
 
Signature · 1 line
1.7.10.4
author
#3 lore raw

PATCH 3/3 extcon: palmas: use dev_get_platdata()

In reply to Jingoo Han

Use the wrapper function for retrieving the platform data instead of accessing dev->platform_data directly. This is a cosmetic change to make the code simpler and enhance the readability.

---
 drivers/extcon/extcon-palmas.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/extcon/extcon-palmas.c +1 -1
index 89fdd05..0c2fb68 100644
@@ -135,7 +135,7 @@ static void palmas_enable_irq(struct palmas_usb *palmas_usb)
 static int palmas_usb_probe(struct platform_device *pdev)
 {
 	struct palmas *palmas = dev_get_drvdata(pdev->dev.parent);
-	struct palmas_usb_platform_data	*pdata = pdev->dev.platform_data;
+	struct palmas_usb_platform_data	*pdata = dev_get_platdata(&pdev->dev);
 	struct device_node *node = pdev->dev.of_node;
 	struct palmas_usb *palmas_usb;
 	int status;
Signature · 1 line
1.7.10.4
maintainer
#4 lore raw
In reply to Jingoo Han

Hi Jingoo,

I prefer to consolidate this patchset as one patch because of simliar moditication.

Thanks,
Chanwoo Choi

Quoted 17 lines · Jingoo Han

Use the wrapper function for retrieving the platform data instead of accessing dev->platform_data directly. This is a cosmetic change to make the code simpler and enhance the readability.

---
 drivers/extcon/extcon-adc-jack.c |    2 +-
 drivers/extcon/extcon-gpio.c     |    2 +-
 drivers/extcon/extcon-palmas.c   |    2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/