Skip to contentSkip to conversation

thermal: dove: remove unnecessary platform_set_drvdata()

PATCH In review Jingoo Han 2 participants 2 messages May 6, 2013 Thermal

lore
Share & tools
lore

Jingoo Han

author
#0 lore raw

PATCH 2/6 thermal: dove: remove unnecessary platform_set_drvdata()

The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.

---
 drivers/thermal/dove_thermal.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/thermal/dove_thermal.c +0 -1
index 4b15a5f..900479e 100644
@@ -182,7 +182,6 @@ static int dove_thermal_exit(struct platform_device *pdev)
 		platform_get_drvdata(pdev);
 
 	thermal_zone_device_unregister(dove_thermal);
-	platform_set_drvdata(pdev, NULL);
 
 	return 0;
 }
Signature · 1 line
1.7.2.5
Acked-by on v1 2/6
#1 lore raw
Quoted 26 lines · Jingoo Han

The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.

---
 drivers/thermal/dove_thermal.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/thermal/dove_thermal.c +0 -1
index 4b15a5f..900479e 100644
@@ -182,7 +182,6 @@ static int dove_thermal_exit(struct platform_device *pdev)
 		platform_get_drvdata(pdev);
 
 	thermal_zone_device_unregister(dove_thermal);
-	platform_set_drvdata(pdev, NULL);
 
 	return 0;
 }
Signature · 1 line
1.7.2.5