spi: bcm63xx: remove unnecessary platform_set_drvdata()
Subsystems (2)
PATCH 4/15 spi: bcm63xx: remove unnecessary platform_set_drvdata()
The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.
Signed-off-by Jingoo Han <[email protected]>
--- drivers/spi/spi-bcm63xx.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-)
drivers/spi/spi-bcm63xx.c +0 -3
@@ -469,7 +469,6 @@ static int bcm63xx_spi_probe(struct platform_device *pdev) out_clk_disable:clk_disable_unprepare (clk); out_err: -platform_set_drvdata (pdev,NULL );spi_master_put (master); out_clk:clk_put (clk);
@@ -491,8 +490,6 @@ static int bcm63xx_spi_remove(struct platform_device *pdev)clk_disable_unprepare (bs->clk);clk_put (bs->clk); -platform_set_drvdata (pdev,0 ); -spi_master_put (master);return 0 ;
Signature · 10 lines
1.7.2.5 ------------------------------------------------------------------------------ Get 100% visibility into Java/.NET code with AppDynamics Lite It's a free troubleshooting tool designed for production Get down to code-level detail for bottlenecks, with <2% overhead. Download for free and get started troubleshooting in minutes. http://p.sf.net/sfu/appdyn_d2d_ap2