S2io: hardware fixes

Hi,
Following are the code changes addressing the hardware errata in user guide.

1. Xena3's with a set of subsystem IDs had Link LED problems, fixed that specifically for them.
2. To write into the Keyed Mac_Cfg register to enable broadcast, writing two 32 bit writes into it along with a write to the key register rather than a single write to key and a 64 bit write to mac_cfg. This is necessary on 32 bit systems where a writeq(64 bit write) is actually two writel (32 bit writes).
3. Writes to some special registers mentioned in UG is being done by a special macro which defines which 32 bits of the 64 bit register is to be written first. Again this applies only on 32 bit systems.
4. Configured pause frame related water marks and a shared_split value which describes the Max TXDMA related split transaction that can be used without giving room for the Rx transactions.
5. The mac_rmac_err_reg R1 register will be cleared in the interrupt handler itself rather than in the scheduled task as was being done previously.
6. Even on PCC_FB_ECC error the card will be reset by disabling adapter enable bit.

Thanks,
Ravi

48 hours passed between patch #3 and patch #4. Is there a problem with your email system?

Also, your patches do not include the "signed-off-by" line described in the two documents I referenced. The "signed-off-by" line makes the lawyers happy.

Since you missed that major legal item, please _read_ the following documents:

http://linux.yyz.us/patch-format.html (see #5, "Sign your work")
http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt

Jeff

Jeff,
Sorry about that. We'll add the signed-off-by line. We are sending the patches as and when they are completed. In the next couple of days, the remaining patches should be done. Do you want us to send them after all are complete or is it okay to send each patch as and when completed ?

Thanks,
Ravi

-----Original Message-----
From: Jeff Garzik [mailto:[email protected]]
Sent: Friday, October 08, 2004 5:11 PM
To: [email protected]
Cc: 'Francois Romieu'; [email protected]; [email protected]; [email protected]; [email protected]
Subject: Re: [PATCH 2.6.9-rc2 4/8] S2io: hardware fixes

48 hours passed between patch #3 and patch #4. Is there a problem with your email system?

Also, your patches do not include the "signed-off-by" line described in the two documents I referenced. The "signed-off-by" line makes the lawyers happy.

Since you missed that major legal item, please _read_ the following documents:

http://linux.yyz.us/patch-format.html (see #5, "Sign your work")
http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt

Jeff

I apply a patch series all at the same time. So, right now I'm waiting for patches 5-8 before I will apply 1-8.

Jeff

Hi,

Maybe you already have this planned or patched, but it wasn't in the "cosmetic" patch file.

In s2io.c, please convert this struct to C99 syntax:

static struct pci_driver s2io_driver = {
      name:"S2IO",
      id_table:s2io_tbl,
      probe:s2io_init_nic,
      remove:__devexit_p(s2io_rem_nic),
};

so that sparse won't complain like so:
drivers/net/s2io.c:238:7: warning: obsolete struct initializer, use C99 syntax drivers/net/s2io.c:239:7: warning: obsolete struct initializer, use C99 syntax drivers/net/s2io.c:240:7: warning: obsolete struct initializer, use C99 syntax drivers/net/s2io.c:241:7: warning: obsolete struct initializer, use C99 syntax

and if you haven't tried sparse on the driver, that would be a good idea.

~Randy