watchdog: ep93xx_wdt: split module author names
PATCH 1/6 watchdog: ep93xx_wdt: split module author names
Split module author names in order to fix the following checkpatch warning.
WARNING: quoted string split across lines
--- drivers/watchdog/ep93xx_wdt.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/watchdog/ep93xx_wdt.c +3 -3
@@ -165,9 +165,9 @@ static struct platform_driver ep93xx_wdt_driver = {module_platform_driver (ep93xx_wdt_driver); -MODULE_AUTHOR ("Ray Lehtiniemi <[email protected]>," -"Alessandro Zummo <[email protected]>," -"H Hartley Sweeten <[email protected]>" ); +MODULE_AUTHOR ("Ray Lehtiniemi <[email protected]>" ); +MODULE_AUTHOR ("Alessandro Zummo <[email protected]>" ); +MODULE_AUTHOR ("H Hartley Sweeten <[email protected]>" );MODULE_DESCRIPTION ("EP93xx Watchdog" );MODULE_LICENSE ("GPL" );MODULE_VERSION (WDT_VERSION );
Signature · 1 line
1.7.10.4
PATCH 2/6 watchdog: pc87413: split module author names
Split module author names and remove unnecessary braces, in order to fix the following checkpatch issues.
WARNING: quoted string split across lines
WARNING: braces {} are not necessary for single statement blocks
--- drivers/watchdog/pc87413_wdt.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
drivers/watchdog/pc87413_wdt.c +3 -4
@@ -512,9 +512,8 @@ static int __init pc87413_init(void)return -EBUSY ; ret =register_reboot_notifier (&pc87413_notifier); -if (ret !=0 ) { +if (ret !=0 )pr_err ("cannot register reboot notifier (err=%d)\n" , ret); - } ret =misc_register (&pc87413_miscdev);if (ret !=0 ) {
@@ -575,8 +574,8 @@ static void __exit pc87413_exit(void)module_init (pc87413_init);module_exit (pc87413_exit); -MODULE_AUTHOR ("Sven Anders <[email protected]>, " -"Marcus Junker <[email protected]>," ); +MODULE_AUTHOR ("Sven Anders <[email protected]>" ); +MODULE_AUTHOR ("Marcus Junker <[email protected]>" );MODULE_DESCRIPTION ("PC87413 WDT driver" );MODULE_LICENSE ("GPL" );
Signature · 1 line
1.7.10.4
Re: [PATCH 2/6] watchdog: pc87413: split module author names
Quoted 7 lines · Jingoo Han
Split module author names and remove unnecessary braces, in order to fix the following checkpatch issues.
WARNING: quoted string split across lines
WARNING: braces {} are not necessary for single statement blocksSigned-off-by Jingoo Han <[email protected]>
PATCH 3/6 watchdog: w83697hf: split module author names
In reply to Jingoo HanSplit module author names and remove unnecessary braces, in order to fix the following checkpatch issue.
WARNING: quoted string split across lines
--- drivers/watchdog/w83697hf_wdt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/watchdog/w83697hf_wdt.c +2 -2
@@ -455,6 +455,6 @@ module_init(wdt_init);module_exit (wdt_exit);MODULE_LICENSE ("GPL" ); -MODULE_AUTHOR ("Marcus Junker <[email protected]>, " -"Samuel Tardieu <[email protected]>" ); +MODULE_AUTHOR ("Marcus Junker <[email protected]>" ); +MODULE_AUTHOR ("Samuel Tardieu <[email protected]>" );MODULE_DESCRIPTION ("w83697hf/hg WDT driver" );
Signature · 1 line
1.7.10.4
Re: [PATCH 3/6] watchdog: w83697hf: split module author names
Quoted 6 lines · Jingoo Han
Split module author names and remove unnecessary braces, in order to fix the following checkpatch issue.
WARNING: quoted string split across lines
Signed-off-by Jingoo Han <[email protected]>
PATCH 4/6 watchdog: ibmasr: fix incorrect placement of __initdata marker
In reply to Jingoo HanThe __initdata marker can be virtually anywhere on the line, EXCEPT right after "struct". The preferred location is before the "=" sign if there is one, or before the trailing ";" otherwise. It also fixes the following chechpatch warning.
WARNING: __initdata should be placed after ibmasr_id_table[]
--- drivers/watchdog/ibmasr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/watchdog/ibmasr.c +1 -1
@@ -360,7 +360,7 @@ struct ibmasr_id {int type; }; -static struct ibmasr_id __initdata ibmasr_id_table[] = { +static struct ibmasr_id ibmasr_id_table[]__initdata = { {"IBM Automatic Server Restart - eserver xSeries 220" ,ASMTYPE_TOPAZ }, {"IBM Automatic Server Restart - Machine Type 8673" ,ASMTYPE_PEARL }, {"IBM Automatic Server Restart - Machine Type 8480" ,ASMTYPE_JASPER },
Signature · 1 line
1.7.10.4
Re: [PATCH 4/6] watchdog: ibmasr: fix incorrect placement of __initdata marker
Quoted 8 lines · Jingoo Han
The
__initdatamarker can be virtually anywhere on the line, EXCEPT right after "struct". The preferred location is before the "=" sign if there is one, or before the trailing ";" otherwise. It also fixes the following chechpatch warning.WARNING:
__initdatashould be placed after ibmasr_id_table[]Signed-off-by Jingoo Han <[email protected]>
PATCH 5/6 watchdog: iTCO_wdt: remove unnecessary spaces
In reply to Jingoo HanRemove unnecessary space in order to fix the following checkpatch issues.
WARNING: please, no space before tabs
--- drivers/watchdog/iTCO_wdt.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/watchdog/iTCO_wdt.c +3 -3
@@ -347,15 +347,15 @@ static const struct watchdog_info ident = {static const struct watchdog_ops iTCO_wdt_ops = { .owner =THIS_MODULE , .start = iTCO_wdt_start, - .stop = iTCO_wdt_stop, - .ping = iTCO_wdt_ping, + .stop = iTCO_wdt_stop, + .ping = iTCO_wdt_ping, .set_timeout = iTCO_wdt_set_timeout, .get_timeleft = iTCO_wdt_get_timeleft, };static struct watchdog_device iTCO_wdt_watchdog_dev = { .info = &ident, - .ops = &iTCO_wdt_ops, + .ops = &iTCO_wdt_ops, };/*
Signature · 1 line
1.7.10.4
Re: [PATCH 5/6] watchdog: iTCO_wdt: remove unnecessary spaces
Quoted 6 lines · Jingoo Han
Remove unnecessary space in order to fix the following checkpatch issues.
WARNING: please, no space before tabs
Signed-off-by Jingoo Han <[email protected]>
PATCH 6/6 watchdog: softdog: remove unnecessary initialization of static variable
In reply to Jingoo HanRemove unnecessary initialization of static variable in order to fix the following checkpatch issue.
ERROR: do not initialise statics to 0 or NULL
--- drivers/watchdog/softdog.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/watchdog/softdog.c +1 -1
@@ -62,7 +62,7 @@ MODULE_PARM_DESC(nowayout,"Watchdog cannot be stopped once started (default=" __MODULE_STRING(WATCHDOG_NOWAYOUT) ")"); -static int soft_noboot =0 ; +static int soft_noboot;module_param (soft_noboot, int,0 );MODULE_PARM_DESC (soft_noboot,"Softdog action, set to 1 to ignore reboots, 0 to reboot (default=0)" );
Signature · 1 line
1.7.10.4
Re: [PATCH 6/6] watchdog: softdog: remove unnecessary initialization of static variable
Quoted 6 lines · Jingoo Han
Remove unnecessary initialization of static variable in order to fix the following checkpatch issue.
ERROR: do not initialise statics to 0 or NULL
Signed-off-by Jingoo Han <[email protected]>
Quoted 6 lines · Jingoo Han
Split module author names in order to fix the following checkpatch warning.
WARNING: quoted string split across lines
Signed-off-by Jingoo Han <[email protected]>
Hi Jingoo,
Quoted 6 lines
Split module author names in order to fix the following checkpatch warning.
WARNING: quoted string split across lines
Signed-off-by Jingoo Han <[email protected]>
This series of 6 patches has been added to linux-watchdog-next as a single patch.
Kind regards,
Wim.