Skip to contentSkip to conversation

ARM: S5PC110: Fix wrong interrupt I2C2 number

PATCH New Kyungmin Park 3 participants 3 messages Sep 30, 2010 – Oct 7, 2010

Subsystems (3)
Arm (32-bit) Arm sub-architectures Arm Samsung Exynos
lore
Share & tools
lore

Kyungmin Park

author
#0 lore raw

PATCH 2/7 ARM: S5PC110: Fix wrong interrupt I2C2 number

From: Kyungmin Park <[email protected]>

It's I2C2 interrupt number instead of CAN0.

Signed-off-by Kyungmin Park <[email protected]>
---
 arch/arm/mach-s5pv210/include/mach/irqs.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
arch/arm/mach-s5pv210/include/mach/irqs.h +2 -2
index cdb8ae4..5ab1833 100644
@@ -55,8 +55,8 @@
 #define IRQ_SPI1		S5P_IRQ_VIC1(16)
 #define IRQ_SPI2		S5P_IRQ_VIC1(17)
 #define IRQ_IRDA		S5P_IRQ_VIC1(18)
-#define IRQ_CAN0		S5P_IRQ_VIC1(19)
-#define IRQ_CAN1		S5P_IRQ_VIC1(20)
+#define IRQ_IIC2		S5P_IRQ_VIC1(19)
+#define IRQ_I2C_HDMI_PHY	S5P_IRQ_VIC1(20)
 #define IRQ_HSIRX		S5P_IRQ_VIC1(21)
 #define IRQ_HSITX		S5P_IRQ_VIC1(22)
 #define IRQ_UHOST		S5P_IRQ_VIC1(23)
Signature · 1 line
1.5.3.3
#1 lore raw

PATCH 2/7 ARM: S5PC110: Fix wrong interrupt I2C2 number

Quoted 17 lines · Kyungmin Park

From: Kyungmin Park <[email protected]>

It's I2C2 interrupt number instead of CAN0.

Signed-off-by Kyungmin Park <[email protected]>
---
 arch/arm/mach-s5pv210/include/mach/irqs.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
arch/arm/mach- renamed from arch/arm/mach-s5pv210/include/mach/irqs.h +0 -0

s5pv210/include/mach/irqs.h
index cdb8ae4..5ab1833 100644

arch/arm/mach-s5pv210/include/mach/irqs.h +0 -0
@@ -55,8 +55,8 @@
 #define IRQ_SPI1		S5P_IRQ_VIC1(16)

arch/arm/mach-s5pv210/include/mach/irqs.h

Quoted 10 lines
arch/arm/mach-s5pv210/include/mach/irqs.h +2 -3
 #define IRQ_SPI2		S5P_IRQ_VIC1(17)
 #define IRQ_IRDA		S5P_IRQ_VIC1(18)
-#define IRQ_CAN0		S5P_IRQ_VIC1(19)
-#define IRQ_CAN1		S5P_IRQ_VIC1(20)
+#define IRQ_IIC2		S5P_IRQ_VIC1(19)
+#define IRQ_I2C_HDMI_PHY	S5P_IRQ_VIC1(20)
 #define IRQ_HSIRX		S5P_IRQ_VIC1(21)
 #define IRQ_HSITX		S5P_IRQ_VIC1(22)
 #define IRQ_UHOST		S5P_IRQ_VIC1(23)
--

Please refer to my other comments.

Hmm...I think, no need to change to IRQ_I2C_HDMI_PHY...in here. If required, we can do it later...and how about IRQ_IIC_HDMI_PHY like other IRQ_IIC?

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.

#2 lore raw

PATCH 2/7 ARM: S5PC110: Fix wrong interrupt I2C2 number

Hello,

Quoted 31 lines · Kukjin Kim
Quoted 17 lines · Kyungmin Park

From: Kyungmin Park <[email protected]>

It's I2C2 interrupt number instead of CAN0.

Signed-off-by Kyungmin Park <[email protected]>
---
 arch/arm/mach-s5pv210/include/mach/irqs.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
arch/arm/mach- renamed from arch/arm/mach-s5pv210/include/mach/irqs.h +0 -0

s5pv210/include/mach/irqs.h
index cdb8ae4..5ab1833 100644

arch/arm/mach-s5pv210/include/mach/irqs.h +0 -0
@@ -55,8 +55,8 @@
 #define IRQ_SPI1		S5P_IRQ_VIC1(16)

arch/arm/mach-s5pv210/include/mach/irqs.h

Quoted 10 lines
arch/arm/mach-s5pv210/include/mach/irqs.h +2 -3
 #define IRQ_SPI2		S5P_IRQ_VIC1(17)
 #define IRQ_IRDA		S5P_IRQ_VIC1(18)
-#define IRQ_CAN0		S5P_IRQ_VIC1(19)
-#define IRQ_CAN1		S5P_IRQ_VIC1(20)
+#define IRQ_IIC2		S5P_IRQ_VIC1(19)
+#define IRQ_I2C_HDMI_PHY	S5P_IRQ_VIC1(20)
 #define IRQ_HSIRX		S5P_IRQ_VIC1(21)
 #define IRQ_HSITX		S5P_IRQ_VIC1(22)
 #define IRQ_UHOST		S5P_IRQ_VIC1(23)
--

Please refer to my other comments.

Quoted 3 lines

Hmm...I think, no need to change to IRQ_I2C_HDMI_PHY...in here. If required, we can do it later...and how about IRQ_IIC_HDMI_PHY like other IRQ_IIC?

IMHO the best option would be to call it just IRQ_IIC3. This way it would be possible just to use the dev-i2c3 from the next patch in this series (once a dummy setup-i2c3 will be provided for s5pv210). Otherwise we would need to create a special dev-i2c-hdmiphy.c just for this case what would be an overhead imho.

Best regards
--
Marek Szyprowski
Samsung Poland R&D Center