Skip to contentSkip to conversation

thermal: spear: remove unnecessary platform_set_drvdata()

PATCH In review Jingoo Han 2 participants 2 messages May 6, 2013 – May 12, 2013 Thermal

lore
Share & tools
lore

Jingoo Han

author
#0 lore raw

PATCH 6/6 thermal: spear: remove unnecessary platform_set_drvdata()

The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.

---
 drivers/thermal/spear_thermal.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/thermal/spear_thermal.c +0 -1
index 3c5ee56..1a14eaa 100644
@@ -174,7 +174,6 @@ static int spear_thermal_exit(struct platform_device *pdev)
 	struct spear_thermal_dev *stdev = spear_thermal->devdata;
 
 	thermal_zone_device_unregister(spear_thermal);
-	platform_set_drvdata(pdev, NULL);
 
 	/* Disable SPEAr Thermal Sensor */
 	actual_mask = readl_relaxed(stdev->thermal_base);
Signature · 1 line
1.7.2.5
Acked-by on v1 6/6
#1 lore raw
Quoted 15 lines · Jingoo Han

The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.

---
 drivers/thermal/spear_thermal.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/thermal/spear_thermal.c +0 -0
index 3c5ee56..1a14eaa 100644

drivers/thermal/spear_thermal.c static int spear_thermal_exit(struct platform_device *pdev) · line 179

Quoted 7 lines
drivers/thermal/spear_thermal.c +0 -1
@@ -174,7 +174,6 @@ static int spear_thermal_exit(struct platform_device *pdev)
        struct spear_thermal_dev *stdev = spear_thermal->devdata;
 
        thermal_zone_device_unregister(spear_thermal);
-       platform_set_drvdata(pdev, NULL);
 
        /* Disable SPEAr Thermal Sensor */
        actual_mask = readl_relaxed(stdev->thermal_base);