Skip to contentSkip to conversation

S2io: optimizations

PATCH In review Ravinandan Arakali 2 participants 2 messages Oct 14, 2004

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Ravinandan Arakali

author
#0 lore raw

PATCH 3/8 S2io: optimizations

Hi,
Following are the optimization-related changes made in this patch.

1. Definitions of LOW and PANIC levels of the Rx buffers have changed.
2. In wait_for_cmd_complete there is no longer a writeq but just a read and wait for strobe bit to reset.
3. In s2io_isr, the isr_lock has been done away with also the NICs interrupt are no longer disabled explicitly on entering the interrupt handler and re-enabled again before leaving it.
4. Also clearing the semaphore "tasklet_status" when exiting erroneously from s2io_isr after failing fill_rx_buffer call.
5. The set/reset Tx Csum function through ethtool was added to the ethtool_ops structure.
6. Added a Rx side error code in the rx_osm_handler function.
7. No longer stopping and waking Tx queue when link state changes in s2io_link function.
8. removed the isr_lock spinlock from the s2io_nic structure.

Signed-off-by Raghavendra Koushik <[email protected]>
#1 lore raw
Quoted 2 lines · Ravinandan Arakali

Hi,
Following are the optimization-related changes made in this patch.

No objections to this patch, but did I miss a description of the following change?

Quoted 8 lines
(quoted diff) +3 -2
-       if ((sp->pkt_cnt[ring] - rxb_size) > 128) {
+       if ((sp->pkt_cnt[ring] - rxb_size) > 16) {
                level = LOW;
-               if (rxb_size < sp->pkt_cnt[ring] / 8)
+               if ((sp->pkt_cnt[ring] - rxb_size) < MAX_RXDS_PER_BLOCK) {
                        level = PANIC;
+               }
        }