Skip to contentSkip to conversation

xfstests: fsstress: fix incorrect if condition check for collapse range mode

PATCH New Namjae Jeon 1 participant 1 message Apr 30, 2014 VFS

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 xfstests: fsstress: fix incorrect if condition check for collapse range mode

There is if condition to be block aligned for off and len of Collapse range. But off and len for all fallocate opearion can be aligned by incorrect if condition check.

---
 ltp/fsstress.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
ltp/fsstress.c +1 -1
index 29fc250..ff9ed12 100644
@@ -2230,7 +2230,7 @@ do_fallocate(int opno, long r, int mode)
 	 * Collapse range requires off and len to be block aligned, make it
 	 * more likely to be the case.
 	 */
-	if (FALLOC_FL_COLLAPSE_RANGE && (opno % 2)) {
+	if ((mode & FALLOC_FL_COLLAPSE_RANGE) && (opno % 2)) {
 		off = ((off + stb.st_blksize - 1) & ~(stb.st_blksize - 1));
 		len = ((len + stb.st_blksize - 1) & ~(stb.st_blksize - 1));
 	}
Signature · 6 lines
1.7.11-rc0

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs