Skip to contentSkip to conversation

hwrng: timeriomem - remove unnecessary platform_set_drvdata()

PATCH In review Jingoo Han 1 participant 1 message May 6, 2013 Hardware random number generator core

lore
Share & tools
lore

Jingoo Han

author
#0 lore raw

PATCH 3/4 hwrng: timeriomem - remove unnecessary platform_set_drvdata()

The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.

---
 drivers/char/hw_random/timeriomem-rng.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
drivers/char/hw_random/timeriomem-rng.c +0 -2
index 3e75737..d2120ba 100644
@@ -192,7 +192,6 @@ out_release_io:
 out_timer:
 	del_timer_sync(&priv->timer);
 out_free:
-	platform_set_drvdata(pdev, NULL);
 	kfree(priv);
 	return err;
 }
@@ -209,7 +208,6 @@ static int timeriomem_rng_remove(struct platform_device *pdev)
 	del_timer_sync(&priv->timer);
 	iounmap(priv->io_base);
 	release_mem_region(res->start, resource_size(res));
-	platform_set_drvdata(pdev, NULL);
 	kfree(priv);
 
 	return 0;
Signature · 1 line
1.7.2.5