: Fix for bug: U-boot environment corrupt by reading uninitialized flash memory instead of RAM.
PATCH 1/1 : Fix for bug: U-boot environment corrupt by reading uninitialized flash memory instead of RAM.
Hello All,
Commit c0559be371b2a64b1a817088c3308688e2182f93 introduces a bug in the environment setting storage in U-boot-1.3.3-rc3. Settings are retrieved from dataflash when only settings in RAM are valid, resulting in corrupt environment settings, failing printenv command, and
duplicate variables.
This patch fixes this by always using the RAM area when it is created and initialized. (Matches more the behavior as it was prior to this particular commit.)
See attached (Sorry, my mailer does not handle inline-patches properly)
Kind Regards,
Remy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix-corrupt-environment.patch
Type: text/x-patch
Size: 1175 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20080506/f81120ca/attachment.bin
PATCH 1/1 : Fix for bug: U-boot environment corrupt by reading uninitialized flash memory instead of RAM.
Quoted 3 lines · Remy Bohmer
This patch fixes this by always using the RAM area when it is created and initialized. (Matches more the behavior as it was prior to this particular commit.)
Hmm...maybe this is a stupid question, but why can't it _always_ use the RAM area to look up the environment? env_init() is one of the first things to be called during bootstrap...
Maybe it's wishful thinking, but if we could get rid of this extra logic, u-boot would become simpler, smaller and faster, right?
Haavard
PATCH 1/1 : Fix for bug: U-boot environment corrupt by reading uninitialized flash memory instead of RAM.
Hello Haavard, Wolfgang
Quoted 5 lines
Hmm...maybe this is a stupid question, but why can't it _always_ use the RAM area to look up the environment?
env_init()is one of the first things to be called during bootstrap...
Maybe it's wishful thinking, but if we could get rid of this extra logic, u-boot would become simpler, smaller and faster, right?
There are no stupid questions, just stupid answers... ;-)
I think it is nicer too, but that appears to me as a good thing to investigate for the next release of U-boot, not changing this on the deadline of the current release.
I think the patch I posted yesterday should be integrated in the current release, because it is limited to fixing a very annoying bug (bogus environment settings on at least the Atmel at91 boards using dataflash as environment settings storage, maybe also other boards) In fact, If it was up to me, I would classify such a bug as a showstopper...
Wolfgang, have you looked at this patch already?
Kind Regards,
Remy
PATCH 1/1 : Fix for bug: U-boot environment corrupt by reading uninitialized flash memory instead of RAM.
Quoted 3 lines · Remy Bohmer
I think it is nicer too, but that appears to me as a good thing to investigate for the next release of U-boot, not changing this on the deadline of the current release.
Yeah, I completely agree. We probably need some time to shake out any fallout from such a change...your change does nothing but fix the problem, so it is much more appropriate at this point.
Haavard
PATCH 1/1 : Fix for bug: U-boot environment corrupt by reading uninitialized flash memory instead of RAM.
In reply to Haavard SkinnemoenQuoted 4 lines · In message <[email protected]> you wrote:
Hmm...maybe this is a stupid question, but why can't it _always_ use the RAM area to look up the environment?
env_init()is one of the first things to be called during bootstrap...
One of the first accesses to the environment happens when we need to read the console baudrate to initialize the serial interface. This happens very, very early in the initialization, long before RAM is even usable.
Quoted 2 lines
Maybe it's wishful thinking, but if we could get rid of this extra logic, u-boot would become simpler, smaller and faster, right?
Unfortunately this is not the case.
Best regards,
Wolfgang Denk
Signature · 4 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de All I ask is a chance to prove that money can't make me happy.
PATCH 1/1 : Fix for bug: U-boot environment corrupt by reading uninitialized flash memory instead of RAM.
In reply to Remy BohmerQuoted 11 lines · In message <[email protected]> you…
Commit
c0559be371b2a64b1a817088c3308688e2182f93introduces a bug in the environment setting storage in U-boot-1.3.3-rc3. Settings are retrieved from dataflash when only settings in RAM are valid, resulting in corrupt environment settings, failing printenv command, and
duplicate variables.This patch fixes this by always using the RAM area when it is created and initialized. (Matches more the behavior as it was prior to this particular commit.)
Sorry, but this patch makes littles sense to me.
Quoted 1 line
See attached (Sorry, my mailer does not handle inline-patches properly)
Chose another one? Or rather use "git-send-email" directly?
- /* if relocated to RAM */
- if (gd->flags & GD_FLG_RELOC)
+ /* if relocated to RAM, OR if the environment in Malloc-ed RAM is valid */
+ if ((gd->flags & GD_FLG_RELOC) || (gd->env_valid))
Let's keep in mind that the normal logic of the U-Boot startup sequence is like this:
* U-Boot boots and initializes the RAM
* U-Boot relocates itself into RAM, sets GD_FLG_RELOC and continues running from RAM
* U-Boot continues with the initialization, for xample by setting up the malloc arena, loading the working copy of the environment into RAM (after which it set's gd->env_valid), etc.
So the relocation to RAM always preceeds any use of malloc() and the setting of gd->env_valid. Or, put the other way round, we always set GD_FLG_RELOC long before gd->env_valid get's set.
Thus your change above is just redundant.
Now, if your board does not perform proper relocation for some reason, it should still set GD_FLG_RELOC at the appropriate place, i. e. as soon as U-Boot is ready for and starts running out of RAM.
Best regards,
Wolfgang Denk
Signature · 4 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Democracy is mob rule, but with income taxes.
PATCH 1/1 : Fix for bug: U-boot environment corruptby reading uninitialized flash memory instead of RAM.
Quoted 29 lines
Quoted 11 lines · In message <[email protected]> you…
Commit
c0559be371b2a64b1a817088c3308688e2182f93introduces a bug in the environment setting storage in U-boot-1.3.3-rc3. Settings are retrieved from dataflash when only settings in RAM are valid, resulting in corrupt environment settings, failing printenv command, and
duplicate variables.This patch fixes this by always using the RAM area when it is created and initialized. (Matches more the behavior as it was prior to this particular commit.)
Sorry, but this patch makes littles sense to me.
Quoted 1 line
See attached (Sorry, my mailer does not handle inline-patches properly)
Chose another one? Or rather use "git-send-email" directly?
- /* if relocated to RAM */
- if (gd->flags&GD_FLG_RELOC)
+ /* if relocated to RAM, OR if the environment in Malloc-ed RAM is valid */
+ if ((gd->flags&GD_FLG_RELOC) || (gd->env_valid))Let's keep in mind that the normal logic of the U-Boot startup sequence is like this:
Quoted 7 lines
* U-Boot boots and initializes the RAM
* U-Boot relocates itself into RAM, setsGD_FLG_RELOCand continues running from RAM
* U-Boot continues with the initialization, for xample by setting up the malloc arena, loading the working copy of the environment into RAM (after which it set'sgd->env_valid), etc.
When you have a dataflash, this is not the normal behaviour.
A typical behaviour of an AT91 would be:
1) BootROM copies initial bootloader (at91bootstrap/dataflashboot) to internal SRAM
2) BootROM jumps to start of initial bootloader
3) Initial bootloader does low-level init (including configuring the SDRAM controller)
4) Initial bootloader copies U-Boot from dataflash to SDRAM
5) Initial bootloader jumps to U-Boot
6) U-Boot needs to skip low-level init
Quoted 7 lines
So the relocation to RAM always preceeds any use of
malloc()and the setting ofgd->env_valid. Or, put the other way round, we always setGD_FLG_RELOClong beforegd->env_validget's set.Thus your change above is just redundant.
Quoted 8 lines
Now, if your board does not perform proper relocation for some reason, it should still set
GD_FLG_RELOCat the appropriate place, i. e. as soon as U-Boot is ready for and starts running out of RAM.Best regards,
Wolfgang Denk
Best Regards
Ulf Samuelsson
PATCH 1/1 : Fix for bug: U-boot environment corruptby reading uninitialized flash memory instead of RAM.
Quoted 12 lines · In message <[email protected]> you wrote:
Quoted 11 lines
Let's keep in mind that the normal logic of the U-Boot startup sequence is like this:
* U-Boot boots and initializes the RAM
* U-Boot relocates itself into RAM, setsGD_FLG_RELOCand continues running from RAM
* U-Boot continues with the initialization, for xample by setting up the malloc arena, loading the working copy of the environment into RAM (after which it set'sgd->env_valid), etc.
Quoted 1 line
When you have a dataflash, this is not the normal behaviour.
Well, it is still the normal behaviour, except that booting from dataflash works differently, i. e. it is a special case.
Quoted 7 lines
A typical behaviour of an AT91 would be:
1) BootROM copies initial bootloader (at91bootstrap/dataflashboot) to internal SRAM
2) BootROM jumps to start of initial bootloader
3) Initial bootloader does low-level init (including configuring the SDRAM controller)
4) Initial bootloader copies U-Boot from dataflash to SDRAM
5) Initial bootloader jumps to U-Boot
Yes, I am aware of this sequence. I wanted to explain that it is the responsibility of the running code to make sure that GD_FLG_RELOC is set before any of the "real" U-Boot code gets executed. It seems, this is missing in the case described here.
Quoted 1 line
6) U-Boot needs to skip low-level init
It may skip the normal low-level init sequence, but it still has to set up the same environment that normally is set up by that code.
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de "Well I don't see why I have to make one man miserable when I can make so many men happy." - Ellyn Mustard, about marriage
PATCH 1/1 : Fix for bug: U-boot environment corrupt by reading uninitialized flash memory instead of RAM.
In reply to Wolfgang DenkHello Wolfgang,
2008/5/9 Wolfgang Denk <[email protected]>:
Quoted 11 lines
Quoted 9 lines · In message <[email protected]> you…
Commit
c0559be371b2a64b1a817088c3308688e2182f93introduces a bug in the environment setting storage in U-boot-1.3.3-rc3. Settings are retrieved from dataflash when only settings in RAM are valid, resulting in corrupt environment settings, failing printenv command, and
duplicate variables.
This patch fixes this by always using the RAM area when it is created and initialized. (Matches more the behavior as it was prior to this particular commit.)Sorry, but this patch makes littles sense to me.
If you do not like the way it is fixed, then remove git-commit c0559be371b2a64b1a817088c3308688e2182f93 which causes this regression for the time being, to buy more time to fix it in a different/better way for the next release. Now with this commit the complete at91-board series (boards that boot from dataflash or nandflash) are broken. So,we have a serious regression here.
BTW: If you look at the code _before_ commit c0559be371b2a64b1a817088c3308688e2182f93 you will see that immediately when the gd->env_valid is set to 1, _always_ the memory routines are used to read the environment settings. It has been that for many years. Commit c0559be371b2a64b1a817088c3308688e2182f93 changes this behavior, although it suggests that it only would change the use of early global variables. Notice that this commit is more like a cosmetic change, so it would do no harm to leave it out until the next release.
With my patch I tried to get this old behavior back in the tree, and therefor it should work properly for other boards as well. Even if it sounds redundant.
Quoted 2 lines
Quoted 1 line
See attached (Sorry, my mailer does not handle inline-patches properly)
Chose another one? Or rather use "git-send-email" directly?
Stuck to company rules, and from behind a http-proxy, which blocks this kind of traffic? No way is that going to work...
Quoted 3 lines
Let's keep in mind that the normal logic of the U-Boot startup sequence is like this:
* U-Boot boots and initializes the RAM
Nope, not on AT91 with dataflash (or nandflash) boot... AT91Bootstrap is used to initialize the RAM, copies the U-boot code from serial dataflash (SPI bus) to RAM, and then starts executing U-Boot.
Quoted 2 lines
* U-Boot relocates itself into RAM, sets
GD_FLG_RELOCand continues running from RAM
U-boot will not _relocate_ itself in RAM, because it is already there. CONFIG_SKIP_RELOCATE_UBOOT is set for these boards, so GD_FLG_RELOC is never set.
Quoted 7 lines
* U-Boot continues with the initialization, for xample by setting up the malloc arena, loading the working copy of the environment into RAM (after which it set's
gd->env_valid), etc.
So the relocation to RAM always preceeds any use ofmalloc()and the setting ofgd->env_valid. Or, put the other way round, we always setGD_FLG_RELOClong beforegd->env_validget's set.
Thus your change above is just redundant.
Not on AT91, because GD_FLG_RELOC is never set on AT91.
Quoted 3 lines
Now, if your board does not perform proper relocation for some reason, it should still set
GD_FLG_RELOCat the appropriate place, i. e. as soon as U-Boot is ready for and starts running out of RAM.
Figuring this out would take some time, and if you want to freeze 1.3.3 in the mean time, I would suggest to leave this commit out until there is a proper fix for this regression. I can start looking at it again next week, maybe Stelian (who created the AT91 board support in the first place) is faster than me...
Kind Regards,
Remy
PATCH 1/1 : Fix for bug: U-boot environment corrupt by reading uninitialized flash memory instead of RAM.
Quoted 7 lines · In message <[email protected]> you…
If you do not like the way it is fixed, then remove git-commit
c0559be371b2a64b1a817088c3308688e2182f93which causes this regression for the time being, to buy more time to fix it in a different/better way for the next release. Now with this commit the complete at91-board series (boards that boot from dataflash or nandflash) are broken. So,we have a serious regression here.
That's what I did now: I reverted commit c0559be3.
Joakim, please re-submit after the problems were understood and fixed.
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de There's another way to survive. Mutual trust -- and help. -- Kirk, "Day of the Dove", stardate unknown
PATCH 1/1 : Fix for bug: U-boot environment corrupt by reading uninitialized flash memory instead of RAM.
Quoted 9 lines · Wolfgang Denk
Quoted 7 lines · In message <[email protected]> you…
If you do not like the way it is fixed, then remove git-commit
c0559be371b2a64b1a817088c3308688e2182f93which causes this regression for the time being, to buy more time to fix it in a different/better way for the next release. Now with this commit the complete at91-board series (boards that boot from dataflash or nandflash) are broken. So,we have a serious regression here.
Quoted 3 lines
That's what I did now: I reverted commit
c0559be3.Joakim, please re-submit after the problems were understood and fixed.
You want me to resubmit something I got no control over? That won't happen and I doubt the problem boards will care either so I guess this improvement is lost.
Jocke
PATCH 1/1 : Fix for bug: U-boot environment corrupt by reading uninitialized flash memory instead of RAM.
Quoted 22 lines
-----Original Message-----
From: u-boot-users-bounces at lists.sourceforge.net [mailto:u-boot-users-bounces at lists.sourceforge.net] On Behalf Of Joakim Tjernlund
Sent: den 12 maj 2008 09:26
To: Wolfgang Denk
Cc: Haavard Skinnemoen; u-boot-users at lists.sourceforge.net; Nicolas FERRE
Subject: Re: [U-Boot-Users] [PATCH]: Fix for bug: U-boot environment corrupt by reading uninitialized flash memory instead of RAM.Quoted 11 lines · Wolfgang Denk
Quoted 7 lines · In message <[email protected]> you…
If you do not like the way it is fixed, then remove git-commit
c0559be371b2a64b1a817088c3308688e2182f93which causes this regression for the time being, to buy more time to fix it in a different/better way for the next release. Now with this commit the complete at91-board series (boards that boot from dataflash or nandflash) are broken. So,we have a serious regression here.That's what I did now: I reverted commit
c0559be3.
Quoted 7 lines
Quoted 1 line
Joakim, please re-submit after the problems were understood and fixed.
You want me to resubmit something I got no control over? That won't happen and I doubt the problem boards will care either so I guess this improvement is lost.
Jocke
Has the problem boards been fixed yet? If so please resubmit commit c0559be3.
Jocke
PATCH 1/1 : Fix for bug: U-boot environment corrupt by reading uninitialized flash memory instead of RAM.
Quoted 12 lines · In message <005801c8c0f0$2baed020$830c7060$@[email protected]> you wrote:
Quoted 12 lines
Quoted 11 lines
Quoted 7 lines
If you do not like the way it is fixed, then remove git-commit
c0559be371b2a64b1a817088c3308688e2182f93which causes this regression for the time being, to buy more time to fix it in a different/better way for the next release. Now with this commit the complete at91-board series (boards that boot from dataflash or nandflash) are broken. So,we have a serious regression here.That's what I did now: I reverted commit
c0559be3.Joakim, please re-submit after the problems were understood and fixed.
Quoted 7 lines
Quoted 5 lines
You want me to resubmit something I got no control over? That won't happen and I doubt the problem boards will care either so I guess this improvement is lost.
Jocke
Has the problem boards been fixed yet? If so please resubmit commit
c0559be3.
So what *is* the state of this?
If nobody responds soon, I will indeed re-apply that patch, andthen I will not revert this commit again. So if you think this bytes you, please speak up *now*.
Jock, would you please send me a reminder in a week or so? Thanks.
Best regards,
Wolfgang Denk
Signature · 4 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Hindsight is an exact science.
PATCH 1/1 : Fix for bug: U-boot environment corrupt by reading uninitialized flash memory instead of RAM.
Quoted 22 lines · Wolfgang Denk
Quoted 12 lines · In message <005801c8c0f0$2baed020$830c7060$@[email protected]> you wrote:
Quoted 12 lines
Quoted 11 lines
Quoted 7 lines
If you do not like the way it is fixed, then remove git-commit
c0559be371b2a64b1a817088c3308688e2182f93which causes this regression for the time being, to buy more time to fix it in a different/better way for the next release. Now with this commit the complete at91-board series (boards that boot from dataflash or nandflash) are broken. So,we have a serious regression here.That's what I did now: I reverted commit
c0559be3.Joakim, please re-submit after the problems were understood and fixed.
Quoted 7 lines
Quoted 5 lines
You want me to resubmit something I got no control over? That won't happen and I doubt the problem boards will care either so I guess this improvement is lost.
Jocke
Has the problem boards been fixed yet? If so please resubmit commit
c0559be3.
Quoted 8 lines
So what *is* the state of this?
If nobody responds soon, I will indeed re-apply that patch, andthen I will not revert this commit again. So if you think this bytes you, please speak up *now*.
Jock, would you please send me a reminder in a week or so? Thanks.
About week has passed so here is the reminder :)
Jocke
PATCH 1/1 : Fix for bug: U-boot environment corrupt by reading uninitialized flash memory instead of RAM.
Quoted 10 lines · In message <[email protected]> you wrote:
Quoted 8 lines
So what *is* the state of this?
If nobody responds soon, I will indeed re-apply that patch, andthen I will not revert this commit again. So if you think this bytes you, please speak up *now*.
Jock, would you please send me a reminder in a week or so? Thanks.
About week has passed so here is the reminder :)
Unfortunately, the original patch does not apply any more; could you please rebase and resubmit it? Thanks in advance.
Best regards,
Wolfgang Denk
Signature · 7 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
You could end up being oddly sad and full of a strange, diffuse com-
passion which would lead you to believe that it might be a good idea
to wipe out the whole human race and start again with amoebas.
- Terry Pratchett, _Guards! Guards!_PATCH 1/1 : Fix for bug: U-boot environment corrupt by reading uninitialized flash memory instead of RAM.
Quoted 14 lines · Wolfgang Denk
Quoted 10 lines · In message <[email protected]> you wrote:
Quoted 8 lines
So what *is* the state of this?
If nobody responds soon, I will indeed re-apply that patch, andthen I will not revert this commit again. So if you think this bytes you, please speak up *now*.
Jock, would you please send me a reminder in a week or so? Thanks.
About week has passed so here is the reminder :)
Unfortunately, the original patch does not apply any more; could you please rebase and resubmit it? Thanks in advance.
Wolfgang Denk
AppliedPATCH 1/1 : Fix for bug: U-boot environment corrupt by reading uninitialized flash memory instead of RAM.
Quoted 6 lines · In message <[email protected]> you wrote:
Subject: [PATCH] Change
env_get_charfrom a global function ptr to a functionThis avoids an early global data reference
Signed-off-by Joakim Tjernlund <[email protected]>
Quoted 8 lines
---
OK, here it is again. I am on vacation now so I have only compile tested this version.
common/env_common.c | 19 +++++++++++++------ include/environment.h | 4 ++-- 2 files changed, 15 insertions(+), 8 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de [Braddock:] Mr. Churchill, you are drunk. [Churchill:] And you madam, are ugly. But I shall be sober tomorrow.
PATCH 1/1 : Fix for bug: U-boot environment corrupt by reading uninitialized flash memory instead of RAM.
In reply to Wolfgang DenkHello Wolfgang,
Quoted 5 lines
Quoted 1 line
Has the problem boards been fixed yet? If so please resubmit commit
c0559be3.So what *is* the state of this?
If nobody responds soon, I will indeed re-apply that patch, andthen I will not revert this commit again. So if you think this bytes you, please speak up *now*.
Oops, due to my summer holidays I missed this one...
But no problem, I have a decent fix for the AT91 boards ready, and can post it when I am back at work.
I only have to rebase it to the latest git tree.
Remy
PATCH 1/1 : Fix for bug: U-boot environment corrupt by reading uninitialized flash memory instead of RAM.
Hello Wolfgang,
Quoted 6 lines
Quoted 2 lines
Quoted 1 line
Has the problem boards been fixed yet? If so please resubmit commit
c0559be3.So what *is* the state of this?
Oops, due to my summer holidays I missed this one...
But no problem, I have a decent fix for the AT91 boards ready, and can post it when I am back at work.
I only have to rebase it to the latest git tree.
As promised, I have posted my patch for this problem. You can find with the subject: '[patch 1/1] Set GD_FLG_RELOC for boards skipping relocation to RAM'
Kind Regards,
Remy
A message that is not in the archive (sent off-list or not yet received): -6864379040381327023@unknownmsgid
PATCH 1/1 : Fix for bug: U-boot environment corrupt by reading uninitialized flash memory instead of RAM.
Hello Joakim,
I am currently quite busy with other work (but still U-boot and Atmel boards related), and I still have it on my list, so it still has my attention. I expect to get at it again half next week.
Kind Regards,
Remy
2008/5/28 Joakim Tjernlund <[email protected]>:
Quoted 44 lines
Quoted 22 lines
-----Original Message-----
From: u-boot-users-bounces at lists.sourceforge.net [mailto:u-boot-users-bounces at lists.sourceforge.net] On Behalf Of Joakim Tjernlund
Sent: den 12 maj 2008 09:26
To: Wolfgang Denk
Cc: Haavard Skinnemoen; u-boot-users at lists.sourceforge.net; Nicolas FERRE
Subject: Re: [U-Boot-Users] [PATCH]: Fix for bug: U-boot environment corrupt by reading uninitialized flash memory instead of RAM.Quoted 11 lines · Wolfgang Denk
Quoted 7 lines · In message <[email protected]> you…
If you do not like the way it is fixed, then remove git-commit
c0559be371b2a64b1a817088c3308688e2182f93which causes this regression for the time being, to buy more time to fix it in a different/better way for the next release. Now with this commit the complete at91-board series (boards that boot from dataflash or nandflash) are broken. So,we have a serious regression here.That's what I did now: I reverted commit
c0559be3.Quoted 7 lines
Quoted 1 line
Joakim, please re-submit after the problems were understood and fixed.
You want me to resubmit something I got no control over? That won't happen and I doubt the problem boards will care either so I guess this improvement is lost.
Jocke
Has the problem boards been fixed yet? If so please resubmit commit
c0559be3.Jocke
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
U-Boot-Users mailing list
U-Boot-Users at lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/u-boot-users