Skip to contentSkip to conversation

ASoC: sn624x: use dev_err_probe() for the regmap failure

PATCH In review Aryan Sinha 3 participants 3 messages Nov 4 – Nov 8

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: sn624x: use dev_err_probe() for the regmap failure

dev_err_probe() prints the symbolic errno and stays quiet on
-EPROBE_DEFER. The sn624x prefix goes too, dev_err_probe() already prints the device name..

---
 sound/soc/codecs/sn624x-sdca-sdw.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)
sound/soc/codecs/sn624x-sdca-sdw.c +3 -5
index c9e690482..1a83f0a11 100644
@@ -1736,11 +1736,9 @@ static int sn624x_sdca_sdw_probe(struct sdw_slave *slave,
 	regmap = devm_regmap_init_sdw_mbq_cfg(&slave->dev, slave,
 					      &sn624x_sdca_regmap,
 					      &sn624x_sdca_mbq_cfg);
-	if (IS_ERR(regmap)) {
-		dev_err(&slave->dev, "sn624x: devm_regmap_init_sdw_mbq_cfg failed (%ld)\n",
-			PTR_ERR(regmap));
-		return PTR_ERR(regmap);
-	}
+	if (IS_ERR(regmap))
+		return dev_err_probe(&slave->dev, PTR_ERR(regmap),
+				     "devm_regmap_init_sdw_mbq_cfg failed\n");
 
 	ret = sn624x_sdca_init(&slave->dev, regmap, slave);
 	if (ret < 0)
Signature · 1 line
2.46.0
Acked-by on v1 1/1
#1 lore raw
Quoted 2 lines · Aryan Sinha

dev_err_probe() prints the symbolic errno and stays quiet on -EPROBE_DEFER. ...

Qianghua Wang

Email: [email protected]
Website: https://www.senarytech.com

-----Original Message-----
From: Aryan Sinha [email protected]
Sent: November 4, 2026 23:02
To: bo liu [email protected]; qianghua . wang [email protected]
Cc: Mark Brown [email protected]; Liam Girdwood [email protected]; [email protected]; [email protected]; Aryan Sinha [email protected]
Subject: [PATCH] ASoC: sn624x: use dev_err_probe() for the regmap failure

dev_err_probe() prints the symbolic errno and stays quiet on -EPROBE_DEFER. The sn624x prefix goes too, dev_err_probe() already prints the device name..

---
 sound/soc/codecs/sn624x-sdca-sdw.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)
sound/soc/codecs/sn624x-sdca-sdw.c +3 -5
index c9e690482..1a83f0a11 100644
@@ -1736,11 +1736,9 @@ static int sn624x_sdca_sdw_probe(struct sdw_slave *slave,
 	regmap = devm_regmap_init_sdw_mbq_cfg(&slave->dev, slave,
 					      &sn624x_sdca_regmap,
 					      &sn624x_sdca_mbq_cfg);
-	if (IS_ERR(regmap)) {
-		dev_err(&slave->dev, "sn624x: devm_regmap_init_sdw_mbq_cfg failed (%ld)\n",
-			PTR_ERR(regmap));
-		return PTR_ERR(regmap);
-	}
+	if (IS_ERR(regmap))
+		return dev_err_probe(&slave->dev, PTR_ERR(regmap),
+				     "devm_regmap_init_sdw_mbq_cfg failed\n");
 
 	ret = sn624x_sdca_init(&slave->dev, regmap, slave);
 	if (ret < 0)

--
2.46.0

maintainer
#2 lore raw
In reply to Aryan Sinha
Quoted 1 line · Aryan Sinha

ASoC: sn624x: use dev_err_probe() for the regmap failure

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-7.5

Thanks!

[1/1] ASoC: sn624x: use dev_err_probe() for the regmap failure

      https://git.kernel.org/broonie/sound/c/9d12f5640132

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark