hwmon: (abituguru3) remove unnecessary platform_set_drvdata()
Subsystems (2)
PATCH 1/5 hwmon: (abituguru3) remove unnecessary platform_set_drvdata()
The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.
--- drivers/hwmon/abituguru3.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/hwmon/abituguru3.c +0 -1
@@ -1079,7 +1079,6 @@ static int abituguru3_remove(struct platform_device *pdev)int i;struct abituguru3_data *data =platform_get_drvdata (pdev); -platform_set_drvdata (pdev,NULL );hwmon_device_unregister (data->hwmon_dev);for (i =0 ; data->sysfs_attr[i].dev_attr.attr.name; i++)device_remove_file (&pdev->dev, &data->sysfs_attr[i].dev_attr);
Signature · 8 lines
1.7.2.5 _______________________________________________ lm-sensors mailing list [email protected] http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
Guenter Roeck
maintainerQuoted 6 lines · Jingoo Han
The driver core clears the driver data to NULL after
device_releaseor on probe failure, since commit0998d0631001288a5974afc0b2a5f568bcdecb4d(device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.Signed-off-by Jingoo Han <[email protected]>
Hi,
the entire series was already submitted by Sachin Kamat last Friday, and is already enqueued in my -next tree. It will be visible in the -next tree after the commit window closes.
Thanks,
Guenter
_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
Quoted 6 lines · Guenter Roeck
Quoted 5 lines · Jingoo Han
The driver core clears the driver data to NULL after
device_releaseor on probe failure, since commit0998d0631001288a5974afc0b2a5f568bcdecb4d(device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.
Quoted 7 lines
Quoted 1 line
Signed-off-by Jingoo Han <[email protected]>Hi,
the entire series was already submitted by Sachin Kamat last Friday, and is already enqueued in my -next tree. It will be visible in the -next tree after the commit window closes.
Hi Guenter Roeck,
OK, I see. :)
Thank you.
Quoted 3 lines
Thanks,
Guenter
_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors