spi: pxa2xx: remove unnecessary platform_set_drvdata()

PATCH Superseded Jingoo Han 1 participant 1 message May 3, 2013

Subsystems (3)

SPI PXA2xx/PXA3xx support Intel LPSS (Low Power SubSystem) drivers

lore

Share & tools

lore

Jingoo Han

author

2013-05-03 06:53 UTC #0 lore raw

PATCH 14/15 spi: pxa2xx: remove unnecessary platform_set_drvdata()

The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL.

Signed-off-by Jingoo Han <[email protected]>

---
 drivers/spi/spi-pxa2xx.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

drivers/spi/spi-pxa2xx.c +0 -3

index f5d84d6..5a7fa2c 100644
@@ -1299,9 +1299,6 @@ static int pxa2xx_spi_remove(struct platform_device *pdev)
 	/* Disconnect from the SPI framework */
 	spi_unregister_master(drv_data->master);
 
-	/* Prevent double remove */
-	platform_set_drvdata(pdev, NULL);
-
 	return 0;
 }

Signature · 10 lines

1.7.2.5



------------------------------------------------------------------------------
Get 100% visibility into Java/.NET code with AppDynamics Lite
It's a free troubleshooting tool designed for production
Get down to code-level detail for bottlenecks, with <2% overhead.
Download for free and get started troubleshooting in minutes.
http://p.sf.net/sfu/appdyn_d2d_ap2